Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI around docbuilds #1275

Open
2 tasks
aaronjeline opened this issue Oct 11, 2024 · 1 comment
Open
2 tasks

Improve CI around docbuilds #1275

aaronjeline opened this issue Oct 11, 2024 · 1 comment
Labels
internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice

Comments

@aaronjeline
Copy link
Contributor

Describe the improvement you'd like to request

4.2.0 launch accidentally had a build error in our docs that CI didn't catch. It would be nice to catch this.

Describe alternatives you've considered

No response

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this internal improvement
  • ⚠️ This feature might incur a breaking change
@aaronjeline aaronjeline added the internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice label Oct 11, 2024
@john-h-kastner-aws
Copy link
Contributor

john-h-kastner-aws commented Oct 11, 2024

Problematic line was here (still a problem on main at time of comment):

#[doc = include_str!("../../cedar-policy/experimental_warning.md")]

To detect this we would need to build the validator crate in an environment without the cedar-policy directory. I don't believe it would be enough to just cd into the validator crate and build docs from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice
Projects
None yet
Development

No branches or pull requests

2 participants