Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert WASM build workaround when wasm-bindgen is fixed for Rust 1.82 #1292

Open
2 tasks
john-h-kastner-aws opened this issue Oct 24, 2024 · 1 comment
Open
2 tasks

Revert WASM build workaround when wasm-bindgen is fixed for Rust 1.82 #1292

john-h-kastner-aws opened this issue Oct 24, 2024 · 1 comment
Labels
internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice

Comments

@john-h-kastner-aws
Copy link
Contributor

john-h-kastner-aws commented Oct 24, 2024 •
edited
Loading

Describe the improvement you'd like to request

We will likely merge #1288 or #1291 to work around a build failure due to wasm-bindgen producing invalid typescript binding (rustwasm/wasm-bindgen#4207).

Revert the work around once that issue is fixed and we verify the build works again.

Describe alternatives you've considered

No response

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this internal improvement
  • ⚠️ This feature might incur a breaking change
@john-h-kastner-aws john-h-kastner-aws added pending-triage The cedar maintainers haven't looked at this yet. Automicaly added to all new issues. internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice and removed pending-triage The cedar maintainers haven't looked at this yet. Automicaly added to all new issues. labels Oct 24, 2024
@john-h-kastner-aws
Copy link
Contributor Author

Linked issue is resolved, waiting on new release of wasm-bindgen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@john-h-kastner-aws