Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[partial-eval][cli] Add schema support to partially-authorize CLI command #1332

Open
2 tasks
palpatim opened this issue Nov 21, 2024 · 1 comment
Open
2 tasks
Labels
feature-request This issue requets a substantial new feature

Comments

@palpatim
Copy link

Category

CLI features/changes

Describe the feature you'd like to request

The authorize CLI command includes schema and schema-format options that inform the evaluation, but partially-authorize lacks that support. This came up as I was trying to get a partial evaluation for an action that was a member of an action group. My policy was written to specify the action group, and my entities file did not include the action hierarchy, so partially-authorize returned a DENY instead of the expected residual.

Describe alternatives you've considered

Do not support this feature. I'm unclear on the benefits of providing a schema to the decision -- it may be that it's redundant with providing the hierarchy definitions in an entity slice, and there may be design reasons for preferring to receive that information in entities rather than schemas.

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change
@palpatim palpatim added feature-request This issue requets a substantial new feature pending-triage The cedar maintainers haven't looked at this yet. Automicaly added to all new issues. labels Nov 21, 2024
@shaobo-he-aws shaobo-he-aws added pending-review A Cedar maintainer has looked at this, but believes it needs review by more of the core team and removed pending-triage The cedar maintainers haven't looked at this yet. Automicaly added to all new issues. labels Nov 21, 2024
@john-h-kastner-aws
Copy link
Contributor

Thanks for opening this issue. partially-authorize should definitely be able to accept a schema

@john-h-kastner-aws john-h-kastner-aws removed the pending-review A Cedar maintainer has looked at this, but believes it needs review by more of the core team label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request This issue requets a substantial new feature
Projects
None yet
Development

No branches or pull requests

3 participants