Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse code between CST->EST and CST->AST conversion #1341

Open
2 tasks
shaobo-he-aws opened this issue Nov 27, 2024 · 1 comment
Open
2 tasks

Reuse code between CST->EST and CST->AST conversion #1341

shaobo-he-aws opened this issue Nov 27, 2024 · 1 comment
Labels
help-wanted Community help desired. We have not scheduled time to fix this, but think it important. internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice

Comments

@shaobo-he-aws
Copy link
Contributor

Describe the improvement you'd like to request

Both conversions share similar logic, e.g., desugaring the extended has operator. It would be ideal that they use the same code.

Describe alternatives you've considered

No response

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this internal improvement
  • ⚠️ This feature might incur a breaking change
@shaobo-he-aws shaobo-he-aws added pending-triage The cedar maintainers haven't looked at this yet. Automicaly added to all new issues. internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice help-wanted Community help desired. We have not scheduled time to fix this, but think it important. and removed pending-triage The cedar maintainers haven't looked at this yet. Automicaly added to all new issues. labels Nov 27, 2024
@john-h-kastner-aws
Copy link
Contributor

poc: main...expr-builder-trait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help-wanted Community help desired. We have not scheduled time to fix this, but think it important. internal-improvement Refactoring, minor performance improvement, or other changes that Cedar users may never notice
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shaobo-he-aws @john-h-kastner-aws