Check that action scope constriant do not contain non-actions entities in EST #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
john-h-kastner-aws
changed the title
shaobo-he-aws
approved these changes
Jun 1, 2024
Signed-off-by: John Kastner <[email protected]>
Signed-off-by: John Kastner <[email protected]>
Signed-off-by: John Kastner <[email protected]>
john-h-kastner-aws
force-pushed
the
fix_925
branch
from
2e5fde4
to
04dc835
Compare
|
|
||
| /// Check that all of the EUIDs in an action constraint have the type | ||
| /// `Action`, under an arbitrary namespace. | ||
| pub fn contains_only_action_types(self) -> Result<Self, NonEmpty<Arc<EntityUID>>> { |
There was a problem hiding this comment.
self to &self and NonEmpty<Arc<EntityUID>> to NonEmpty<&EntityUid>?
khieta
pushed a commit
that referenced
this pull request
Aug 9, 2024
…s in EST (#943) Signed-off-by: John Kastner <[email protected]>
khieta
added a commit
that referenced
this pull request
Aug 9, 2024
…943) (#1135) Signed-off-by: John Kastner <[email protected]> Co-authored-by: John Kastner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Backwards compatible if we are happy to call this a bug fix
Issue #, if available
#925
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy(e.g., addition of a new API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):