Revise APIs of PrincipalOrResourceConstraint
#954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ResourceConstraint::get_euid` The original function returns an iterator that works on at most one element. So, this PR replaces it with a function returning an `Option` so that we can pattern match the return value more conveniently. Signed-off-by: Shaobo He <[email protected]>
shaobo-he-aws
requested review from
john-h-kastner-aws,
cdisselkoen,
andrewmwells-amazon,
khieta and
aaronjeline
and removed request for
john-h-kastner-aws and
cdisselkoen
shaobo-he-aws
changed the title
PrincipalOrResourceConstraint::iter_euids with ResourceConstraint::get_euidPrincipalOrResourceConstraint::iter_euids with PrincipalOrResourceConstraint::get_euid
Signed-off-by: Shaobo He <[email protected]>
shaobo-he-aws
changed the title
PrincipalOrResourceConstraint::iter_euids with PrincipalOrResourceConstraint::get_euidPrincipalOrResourceConstraint
cdisselkoen
approved these changes
Jun 5, 2024
Co-authored-by: Craig Disselkoen <[email protected]>
andrewmwells-amazon
approved these changes
Jun 5, 2024
|
Looks like the downstream DRT will need to be fixed but the Java failure on Mac seems to be a glitch. |
shaobo-he-aws
added a commit
to cedar-policy/cedar-spec
that referenced
this pull request
Jun 5, 2024
Signed-off-by: Shaobo He <[email protected]>
shaobo-he-aws
added a commit
to cedar-policy/cedar-spec
that referenced
this pull request
Jun 5, 2024
Signed-off-by: Shaobo He <[email protected]>
aaronjeline
pushed a commit
to cedar-policy/cedar-spec
that referenced
this pull request
Jun 6, 2024
Signed-off-by: Shaobo He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
PrincipalOrResourceConstraint::iter_euidswithPrincipalOrResourceConstraint::get_euidOptionso that we can pattern match the return value more conveniently.NameandEntityUIDwithArcIssue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy-core,cedar-validator, etc.)I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):