Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for Slack Apps Distribution #3

Open
3 of 4 tasks
cedricium opened this issue Aug 18, 2018 · 0 comments
Open
3 of 4 tasks

Prepare for Slack Apps Distribution #3

cedricium opened this issue Aug 18, 2018 · 0 comments
Assignees
@cedricium

Comments

@cedricium
Copy link
Owner

cedricium commented Aug 18, 2018 •
edited
Loading

Some security, error handling, and marketing tasks will be needed before distribution on slack.com/apps. Those tasks are outlined below:

  • make sure to follow Slack's guidelines / best practices [2][3][4]
  • verify requests to server originate from Slack [0] - done: 15c5182
  • implement feedback <text> command (less important) - done: 86836ce
  • implement proper error handling and fail safely [1] - already implemented

Resources:
[0]: https://api.slack.com/docs/verifying-requests-from-slack
[1]: https://api.slack.com/slash-commands#responding_with_errors
[2]: https://api.slack.com/docs/message-guidelines
[3]: https://api.slack.com/docs/slack-apps-checklist
[4]: https://api.slack.com/docs/slack-apps-guidelines
cedricium added a commit that referenced this issue Aug 18, 2018
@cedricium
fix: implement slack request verification
15c5182 
To ensure the server is not abused by outside entities, verifying we
only respond to requests originating from Slack has been implemented.

Relates: #3
cedricium added a commit that referenced this issue Aug 19, 2018
@cedricium
fix: add feedback command for distribution prep
b598ae5 
Relates to: #3
cedricium added a commit that referenced this issue Aug 19, 2018
@cedricium
fix: add feedback command for distribution prep
86836ce 
Relates to: #3
@cedricium cedricium self-assigned this Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cedricium cedricium

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cedricium