Skip to content

feat: return sdk response with more fields inc the signer #6036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Nov 3, 2025
Merged

feat: return sdk response with more fields inc the signer #6036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
ab4ab23
feat: return sdk response with more fields inc the signer
ninabarbakadze Oct 16, 2025
f9e0b26
test: add tests to assert that the fields are set
ninabarbakadze Oct 17, 2025
6d21802
fix: override v1 blob signer with tx signer (#5974)
ninabarbakadze Oct 17, 2025
455ffa7
chore: minor adjustments
ninabarbakadze Oct 17, 2025
58303ea
feat: create the v2 txclient wrapper
ninabarbakadze Oct 21, 2025
dee1ea4
style: fix lint
ninabarbakadze Oct 21, 2025
1f9897b
chore: bump sdk version
ninabarbakadze Oct 22, 2025
c8b6361
chore: merge
ninabarbakadze Oct 22, 2025
d6e9a00
test: add one more test case
ninabarbakadze Oct 22, 2025
56652b6
fix: square size test
ninabarbakadze Oct 22, 2025
595bc96
test: make log less speciifc because heights seem diff for each runs
ninabarbakadze Oct 22, 2025
d7fffae
feat: signers from tx status get set correctly
ninabarbakadze Oct 23, 2025
4b8e0f4
chore: bump sdk
ninabarbakadze Oct 30, 2025
2022fe9
chore: merge
ninabarbakadze Oct 30, 2025
fb02cfa
chore: update go sum in docker
ninabarbakadze Oct 30, 2025
8c2d9ea
Apply suggestions from code review
ninabarbakadze Nov 3, 2025
692baae
refactor: address review comments
ninabarbakadze Nov 3, 2025
4fdfd1e
Merge branch 'main' into nina/extend-tx-resp
ninabarbakadze Nov 3, 2025
e07e24c
fix: lint
ninabarbakadze Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/grpc/tx/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,5 +84,9 @@ func (s *txServer) TxStatus(ctx context.Context, req *TxStatusRequest) (*TxStatu
ExecutionCode: resTx.ExecutionCode,
Error: resTx.Error,
Status: resTx.Status,
GasWanted: resTx.GasWanted,
GasUsed: resTx.GasUsed,
Codespace: resTx.Codespace,
Signers: resTx.Signers,
}, nil
}
229 changes: 206 additions & 23 deletions app/grpc/tx/tx.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions app/test/square_size_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,6 @@ func (s *SquareSizeIntegrationTest) SetupBlockSizeParams(t *testing.T, squareSiz

res, err := txClient.SubmitTx(s.cctx.GoContext(), []sdk.Msg{msgSubmitProp}, opt)
require.NoError(t, err)

res, err = txClient.ConfirmTx(s.cctx.GoContext(), res.TxHash)
require.NoError(t, err)
require.Equal(t, uint32(0), res.Code)

txService := sdktx.NewServiceClient(s.cctx.GRPCClient)
Expand Down
2 changes: 1 addition & 1 deletion cmd/celestia-appd/cmd/override_p2p_config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ func TestOverrideP2PConfig_Integration(t *testing.T) {
configPath := filepath.Join(configDir, "config.toml")
tmcfg.WriteConfigFile(configPath, cfg)

// Create a mock cobra command with server context
// Create a mock cobra command with server context
cmd := &cobra.Command{
Use: "test",
}
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ replace (
cosmossdk.io/api => github.com/celestiaorg/cosmos-sdk/api v0.7.6
cosmossdk.io/x/upgrade => github.com/celestiaorg/cosmos-sdk/x/upgrade v0.2.0
github.com/cometbft/cometbft => github.com/celestiaorg/celestia-core v0.39.12
github.com/cosmos/cosmos-sdk => github.com/celestiaorg/cosmos-sdk v0.51.4
github.com/cosmos/cosmos-sdk => github.com/celestiaorg/cosmos-sdk v0.51.6
github.com/cosmos/ibc-go/v8 => github.com/celestiaorg/ibc-go/v8 v8.7.2
// Use ledger-cosmos-go v0.16.0 because v0.15.0 causes "hidapi: unknown failure"
// See https://github.com/celestiaorg/celestia-app/issues/5453
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,8 +785,8 @@ github.com/celestiaorg/celestia-core v0.39.12 h1:SvlGmZr6XmsSeruFDSyz2rQmCdAJT+6
github.com/celestiaorg/celestia-core v0.39.12/go.mod h1:GxCnrVUUJZ3dtpNlKfHw3otb5TqyOdwjXef1/pNqSzA=
github.com/celestiaorg/celestia-core v1.55.0-tm-v0.34.35 h1:FREwqZwPvYsodr1AqqEIyW+VsBnwTzJNtC6NFdZX8rs=
github.com/celestiaorg/celestia-core v1.55.0-tm-v0.34.35/go.mod h1:SI38xqZZ4ccoAxszUJqsJ/a5rOkzQRijzHQQlLKkyUc=
github.com/celestiaorg/cosmos-sdk v0.51.4 h1:4yQQ+3NqvfcrO3Im1dbzSPF7Ujvw8P0IIisRWVXjWLg=
github.com/celestiaorg/cosmos-sdk v0.51.4/go.mod h1:YRNOXtC4vo5FG1SSoj57yEUiidU8Pn3ofjqYlFdu8qg=
github.com/celestiaorg/cosmos-sdk v0.51.6 h1:sUDSbbg6SjPjWHW7mow4j6i+I8X8nHDmpojnPOeAwYI=
github.com/celestiaorg/cosmos-sdk v0.51.6/go.mod h1:z5sV0ONMM7Qww3FuLZ2xmqjFblbivkb/jmwQfnHAxrE=
github.com/celestiaorg/cosmos-sdk/api v0.7.6 h1:81in9Zk+noz0ko+hZFSSK8L1aawFN8/CmdcQAUhbiUU=
github.com/celestiaorg/cosmos-sdk/api v0.7.6/go.mod h1:1BgQSufu6ZQkst3YBIHDCo/TPUrhfU4fV7tOI0ftql8=
github.com/celestiaorg/cosmos-sdk/x/upgrade v0.2.0 h1:GyDYfK8dLETlUI7F+w+3QYQgAszUegMXgB6cTbDm7CA=
Expand Down
3 changes: 2 additions & 1 deletion pkg/user/mock_tx_server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (

"github.com/celestiaorg/celestia-app/v6/app/grpc/tx"
"github.com/celestiaorg/celestia-app/v6/pkg/user"
"github.com/celestiaorg/celestia-app/v6/pkg/user/utils"
abci "github.com/cometbft/cometbft/abci/types"
"github.com/cometbft/cometbft/rpc/core"
sdk "github.com/cosmos/cosmos-sdk/types"
Expand Down Expand Up @@ -163,7 +164,7 @@ func setupTxClientWithMockServers(t *testing.T, broadcastHandlers []BroadcastHan
}

// Create TxClient with mock connection
encCfg, txClient, _ := setupTxClientWithDefaultParams(t)
encCfg, txClient, _ := utils.SetupTxClientWithDefaultParams(t)

// Build options list
clientOpts := opts
Expand Down
Loading