Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code from the e2e test #1613

Open
evan-forbes opened this issue Feb 12, 2025 · 2 comments
Open

Remove unused code from the e2e test #1613

evan-forbes opened this issue Feb 12, 2025 · 2 comments
Labels
good first issue Good for newcomers WS: Maintenance 🔧

Comments

@evan-forbes
Copy link
Member

in #1609, we introduced a refactored e2e test based on v0.38 of upstream. There were some things such as long running e2e nightlies and digital ocean support that we don't use, therefore should remove.
@tinkerer-shubh
Copy link

Hey! I'd love to work on this issue. Let me know if you'd like me to take it on.

tinkerer-shubh added a commit to tinkerer-shubh/celestia-core that referenced this issue Feb 14, 2025
@tinkerer-shubh
test/e2e: remove unused code
fe02de5 
This commit removes unused code from the e2e test suite following the migration to v0.38:

1. Remove long-running e2e nightlies:\n   - Delete e2e-nightly-34x.yml\n   - Delete e2e-manual.yml\n   - Update references in run-multiple.sh

2. Remove Digital Ocean support:\n   - Remove digitalocean package\n   - Clean up Digital Ocean references\n   - Simplify to Docker-only infrastructure

3. Add documentation about v0.38 migration and Docker-only support

Fixes celestiaorg#1613
@tinkerer-shubh
Copy link

I asked for permission but ended up linking the issue in the commit instead of waiting—apologies for that! I'll create a PR for this now.

@tinkerer-shubh tinkerer-shubh mentioned this issue Feb 14, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers WS: Maintenance 🔧
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evan-forbes @tinkerer-shubh