-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First stab on removing unused code #208
Conversation
fd094da
to
be0607f
Compare
be0607f
to
8780981
Compare
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
+ Coverage 60.77% 62.07% +1.30%
==========================================
Files 262 258 -4
Lines 23734 23016 -718
==========================================
- Hits 14424 14288 -136
+ Misses 7821 7258 -563
+ Partials 1489 1470 -19
|
I think I got too trigger happy yesterday night and deleted too much already 🙈 🤣 |
The tests time out and I don't know why exactly.
Skimming through the logs wasn't insightful either. The only thing I've noticed is that there seem to be more Actually, there are a bunch of |
OK, restarting fixed it here. Locally, the tests did not pass but they time out much later if I close all other processes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ref: #206