Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First stab on removing unused code #208

Merged
merged 7 commits into from
Mar 12, 2021
Merged

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented Mar 11, 2021

ref: #206

@liamsi liamsi force-pushed the ismail/remove_abci_options branch from fd094da to be0607f Compare March 11, 2021 00:44
@liamsi liamsi force-pushed the ismail/remove_abci_options branch from be0607f to 8780981 Compare March 11, 2021 00:45
@codecov-io
Copy link

codecov-io commented Mar 11, 2021

Codecov Report

Merging #208 (c5598c0) into master (591d92b) will increase coverage by 1.30%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   60.77%   62.07%   +1.30%     
==========================================
  Files         262      258       -4     
  Lines       23734    23016     -718     
==========================================
- Hits        14424    14288     -136     
+ Misses       7821     7258     -563     
+ Partials     1489     1470      -19     
Impacted Files Coverage Δ
proxy/client.go 0.00% <0.00%> (-23.08%) ⬇️
test/e2e/generator/generate.go 0.00% <ø> (ø)
blockchain/v2/routine.go 59.15% <0.00%> (-7.05%) ⬇️
blockchain/v0/pool.go 78.32% <0.00%> (-2.29%) ⬇️
p2p/switch.go 63.88% <0.00%> (-2.17%) ⬇️
statesync/snapshots.go 91.59% <0.00%> (-1.69%) ⬇️
mempool/reactor.go 86.36% <0.00%> (-1.52%) ⬇️
blockchain/v0/reactor.go 63.06% <0.00%> (-0.91%) ⬇️
consensus/reactor.go 76.98% <0.00%> (-0.63%) ⬇️
mempool/clist_mempool.go 80.86% <0.00%> (-0.37%) ⬇️
... and 6 more

@liamsi
Copy link
Member Author

liamsi commented Mar 11, 2021

I think I got too trigger happy yesterday night and deleted too much already 🙈 🤣

@liamsi
Copy link
Member Author

liamsi commented Mar 11, 2021

The tests time out and I don't know why exactly.

I[2021-03-11|20:05:03.438] Waiting for all nodes to reach height 1018... 
I[2021-03-11|20:05:03.451] Waiting for all nodes to reach height 1035... 
E[2021-03-11|20:05:30.010] timed out waiting for full01 to reach height 1035 
Error: Process completed with exit code 1.

Skimming through the logs wasn't insightful either. The only thing I've noticed is that there seem to be more p2p.ErrRejected errors than usual. Unclear how this could be related to only keeping builtin abci apps (and removing support for other DBs besides badgersb in e2e tests)

Actually, there are a bunch of Error on broadcastTxCommit module=rpc err="timed out waiting for tx to be included in a block" from the mempool. I'll look into it tomorrow. Maybe I did accidentally delete sth. that is required 😬

@liamsi liamsi marked this pull request as ready for review March 12, 2021 07:27
@liamsi liamsi requested a review from musalbas as a code owner March 12, 2021 07:27
@liamsi
Copy link
Member Author

liamsi commented Mar 12, 2021

OK, restarting fixed it here. Locally, the tests did not pass but they time out much later if I close all other processes.

@liamsi liamsi requested review from evan-forbes and removed request for musalbas March 12, 2021 07:31
Copy link
Collaborator

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liamsi liamsi merged commit 2f9aac7 into master Mar 12, 2021
@liamsi liamsi deleted the ismail/remove_abci_options branch March 12, 2021 09:34
@evan-forbes evan-forbes mentioned this pull request Aug 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants