Write up a Governance Contract wishlist

[aaronmgdr]

Based on the issues we have encountered while building Mondo Create a list of things we would like to be able to access in from governance contract.

Include the data we want (eg cgp url in event) and what issues not having it has created.

[aaronmgdr]

once we have this doc we can meet with mariano and pavel to discuss if the requests can be implemented.

[aaronmgdr]

XS because its doesnt need to be formal essay just list of items and little bit about why they are important.

[nicolasbrugneaux]

more events emitted

Right now, ProposalExpired is never emitted, which can be painful to decide if a proposal is expired or not, would like all stage changes to be emitted

events emitted with meaningful data

so we don't need to rely on archive nodes to grab historical data. For example ProposalDequeued(proposalId, cgpUrl)

actually use the stages defined in Proposal.sol

Right now approval, expiration aren't used at all which makes it hard to determine the stage the proposal is in

new proposal stages

Such as executionPending (approved but not executed yet) or rejected (expired and didnt reach quorum) would go a long way.

keep the proposals in the governance struct

We're talking about less than 300 structs, can't be taking that much storage, and would make getting historical data much more accurate and faster

---

All of these could go a long way, some may overlap, but aren't exclusive. Eg: having more data in events and more events makes storing the proposal long-term less useful, and vice-versa.

[aaronmgdr]

no way to know the dequeue index after execution (include it in the ProposalDequeued event) but it is needed to get the approvers. for a tx

[nicolasbrugneaux]

meaningful public variables in the governance contracts

eg: stageDuration.approval isn't used AFAIK and was used wrongly on mondo to calculate expiration while in approval stage.

[aaronmgdr]

comments do not reflct the actual behavior of the contract. especially regarding Approvals.

[aaronmgdr]

Proposals with 0 transactions ie "tempurature checks" dont expire if they are approved in time but often will not be approved. there is no risk with these proposals as nothing happens on chain so no real safety need for approval.

Id like to propose that 0 transaction proposals can be executed without needing any approvals.