SP-1383: parameterize module discovery tests to clear Sonar smell

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: admirjashari

tests/core/command/module-discovery.spec.ts

@@ -66,48 +66,24 @@ describe("ModuleHandler.discoverAndRegisterModules", () => {
         expect(handler.registeredModules).toHaveLength(0);
     });
 
-    it("warns when the module export is not a class", () => {
-        const root = createCommandsTree({ "notclass/module.js": "module.exports = { notAClass: true };" });
+    it.each([
+        ["export is not a class", "module.exports = { notAClass: true };", "is not a class/constructor function"],
+        ["class has no register method", "module.exports = class {};", "does not have a 'register' method"],
+        ["dependency is missing", "require('a-package-that-does-not-exist-xyz');", "Could not require module"],
+        [
+            "require fails with ENOENT",
+            "require('fs').readFileSync('/no/such/path/xyz-content-cli-test');",
+            "does not contain a compiled module.js file",
+        ],
+        ["require throws unexpectedly", "throw new Error('boom');", "Error processing module in"],
+    ])("logs the expected message when a module's %s", (_case, moduleContent, expectedMessage) => {
+        const root = createCommandsTree({ "mod/module.js": moduleContent });
         const handler = newHandler();
 
         handler.discoverAndRegisterModules(root, false);
 
         expect(handler.registeredModules).toHaveLength(0);
-        expect(messages().some(m => m.includes("is not a class/constructor function"))).toBe(true);
-    });
-
-    it("warns when the module class has no register method", () => {
-        const root = createCommandsTree({ "noregister/module.js": "module.exports = class {};" });
-        const handler = newHandler();
-
-        handler.discoverAndRegisterModules(root, false);
-
-        expect(handler.registeredModules).toHaveLength(0);
-        expect(messages().some(m => m.includes("does not have a 'register' method"))).toBe(true);
-    });
-
-    it("warns when a module cannot be required due to a missing dependency", () => {
-        const root = createCommandsTree({
-            "badrequire/module.js": "require('a-package-that-does-not-exist-xyz');",
-        });
-        const handler = newHandler();
-
-        handler.discoverAndRegisterModules(root, false);
-
-        expect(handler.registeredModules).toHaveLength(0);
-        expect(messages().some(m => m.includes("Could not require module"))).toBe(true);
-    });
-
-    it("warns when requiring a module fails with an ENOENT error", () => {
-        const root = createCommandsTree({
-            "enoent/module.js": "require('fs').readFileSync('/no/such/path/xyz-content-cli-test');",
-        });
-        const handler = newHandler();
-
-        handler.discoverAndRegisterModules(root, false);
-
-        expect(handler.registeredModules).toHaveLength(0);
-        expect(messages().some(m => m.includes("does not contain a compiled module.js file"))).toBe(true);
+        expect(messages().some(m => m.includes(expectedMessage))).toBe(true);
     });
 
     it("logs an error when the commands path is not a directory", () => {
@@ -122,16 +98,6 @@ describe("ModuleHandler.discoverAndRegisterModules", () => {
         expect(messages().some(m => m.includes("Failed to read modules directory"))).toBe(true);
     });
 
-    it("logs an error when requiring a module throws unexpectedly", () => {
-        const root = createCommandsTree({ "throws/module.js": "throw new Error('boom');" });
-        const handler = newHandler();
-
-        handler.discoverAndRegisterModules(root, false);
-
-        expect(handler.registeredModules).toHaveLength(0);
-        expect(messages().some(m => m.includes("Error processing module in"))).toBe(true);
-    });
-
     it("logs an error when the commands directory does not exist", () => {
         const root = fs.mkdtempSync(join(tmpdir(), "mh-nocommands-"));
         createdRoots.push(root);