Allow specifying bundle path #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fad51d0 we removed the thinlinc_server_bundle parameter. This means that the bundle must be in a standard Ansible search path, using the standard bundle filename. This commit re-implements a variation of this parameter, but makes it optional with sensible defaults. This makes it possible for people to use non-standard locations and filenames, but still keeps the intention of the original commit by only requiring the version to be specified in one place. Fixes cendio#42.
|
@Thulium-Drake @samhed it's almost a revert, but not quite. Thoughts? |
|
Looks good to me, clever reuse of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fad51d0 we removed the thinlinc_server_bundle parameter. This means that the bundle must be in a standard Ansible search path, using the standard bundle filename.
This commit re-implements a variation of this parameter, but makes it optional with sensible defaults. This makes it possible for people to use non-standard locations and filenames, but still keeps the intention of the original commit by only requiring the version to be specified in one place.
Fixes #42.