Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up codebase 🌵 #26

Open
7 tasks done
ken-futureverse opened this issue Jul 9, 2022 · 3 comments
Open
7 tasks done

Tidy up codebase 🌵 #26

ken-futureverse opened this issue Jul 9, 2022 · 3 comments
Labels
chore Small tasks keep the codebase nice and tidy topic: 🌵 green Anything related to keeping codebase clean and green

Comments

@ken-futureverse
Copy link
Collaborator

ken-futureverse commented Jul 9, 2022

  • Stick with one way of doing conditional rendering, either use If component or {if} block
  • Remove service/cennznet/src/Transaction.ts class
  • Remove node/types and web/types, then migrate their contents to node/utils and web/utils
  • Migrate all the constants.ts to the apps/gov-website as it needs to match with env file defined there, also remove the .env.development, as what requires can be inferred from the constants.ts
  • Ensure all library type doesn't consume the constants directly, e.g fetchRequiredRegistrars.ts, Transaction.ts
  • Remove node/models
  • Change "Success" step to "Complete"
@ken-futureverse ken-futureverse added chore Small tasks keep the codebase nice and tidy topic: 🌵 green Anything related to keeping codebase clean and green labels Jul 9, 2022
@aidan-starke
Copy link
Collaborator

If we move away from react-extras we can use clsx for classnames

@ken-futureverse
Copy link
Collaborator Author

@aidan-starke could do that too, but I thought you are still keen to use the Choose component?

@aidan-starke
Copy link
Collaborator

yeah just throwing it out there, I think I'm getting used to <If> anyway 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Small tasks keep the codebase nice and tidy topic: 🌵 green Anything related to keeping codebase clean and green
Projects
None yet
Development

No branches or pull requests

2 participants