Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid auto popup of ensureEthereumChain #193

Closed
wants to merge 11 commits into from
Closed

avoid auto popup of ensureEthereumChain #193

wants to merge 11 commits into from

Conversation

aidan-starke
Copy link
Contributor

@aidan-starke aidan-starke commented May 18, 2022 •
edited
Loading

Description

Details

Changes

  • remove ensureEthereumChain from AppSwitch
  • ensureEthereumChain first if connecting metamask on bridge
  • if on bridge and not connected to ethereum, offer link to switch networks
  • only fetch bridge status & verification fee if connected to ethereum

@vercel
Copy link

vercel bot commented May 18, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
app-hub ✅ Ready (Inspect) Visit Preview May 19, 2022 at 8:06PM (UTC)

@vercel vercel bot temporarily deployed to Preview May 18, 2022 22:47 Inactive
ken-futureverse
ken-futureverse requested changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@ken-futureverse ken-futureverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, is this to address Jaffar feedbacks?

providers/MetaMaskWalletProvider.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview May 19, 2022 20:06 Inactive
@ken-futureverse
Copy link
Collaborator

shall we close this in favor of #195 ?

@aidan-starke
Copy link
Contributor Author

reworked in #195

@aidan-starke aidan-starke deleted the hotfix/connect-metamask-on-bridge branch May 22, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ken-futureverse ken-futureverse ken-futureverse requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bridge page tries to connect MetaMask before Connect Wallet is clicked
2 participants
@aidan-starke @ken-futureverse