This repository has been archived by the owner on Nov 14, 2022. It is now read-only.
Spike: Referendum-Relayer: Display veto percentage #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ken-futureverse
suggested changes
Jun 29, 2022
| const totalStaked = ( | ||
| (await cennzApi.query.staking.erasTotalStake(stakingEra)) as u128 | ||
| ).toNumber(); | ||
|
|
There was a problem hiding this comment.
Use Promise.all here
There was a problem hiding this comment.
cennzApi.query.staking.erasTotalStake relies on the result from the first promise
| @@ -19,4 +19,11 @@ export interface ReferendumMessageBody { | |||
| proposal: ProposalInterface; | |||
| referendum?: ReferendumInterface; | |||
| vetoSum: number; | |||
| vetoThreshold?: number; | |||
| vetoPercentage?: string; | |||
There was a problem hiding this comment.
should vetoPercentage be number too?
There was a problem hiding this comment.
It is a string as I'm using toFixed(), I was tossing up between using 0 and 2 decimal places, what do you think?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
What is changing
fetchVetoPercentageutilnew, fetch and display veto thresholdupdate, fetch and display veto percentageScreenshot