Skip to content
This repository has been archived by the owner on Mar 20, 2020. It is now read-only.

Latest commit

 

History

History
20 lines (19 loc) · 1.03 KB

PULL_REQUEST_TEMPLATE.md

File metadata and controls

20 lines (19 loc) · 1.03 KB

Thank you for your Pull Request! Before submitting, please run through the following checklist:

  • Add a description summarizing the PR, e.g.:
    • What does it do?
    • What important points should reviewers know?
    • Is there something left for follow-up PRs?
    • For large diffs please include a changelog in the description with a bulleted "Adds | Changes | Fixes | Removes" sections
  • Add Apache 2.0 license header for new files
  • Mention the related issue, if any, e.g. Fixes #228 or Related #1337.
  • Unit tests
  • Integration tests, if appropriate
  • Request reviewers. If you aren't sure, start with GH suggestions.
  • Update rustdoc comments with changes
  • Update README with changes, if appropriate
  • Adhere to the style guide
    • In particular, mind the maximal line length.
    • There is no commented code checked in unless necessary.
    • Any panics have a proof or removed.
  • Bumped the runtime version if there are breaking changes in the runtime.