From aa8b0ae4287b464277a31ab9d327259b93e72b3e Mon Sep 17 00:00:00 2001 From: Alexander Emelin Date: Wed, 11 Jan 2023 20:21:11 +0200 Subject: [PATCH] up centrifuge to fix large message decoding --- CHANGELOG.md | 7 +++++++ go.mod | 4 ++-- go.sum | 8 ++++---- misc/release/notes.md | 13 +------------ 4 files changed, 14 insertions(+), 18 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 37920ce705..84e0fafd91 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,10 @@ +v4.1.2 +====== + +### Fixes + +* Fix decoding of large protocol messages. The bug was introduced by v4.1.1. See [bug report](https://github.com/centrifugal/centrifugo/issues/603) + v4.1.1 ====== diff --git a/go.mod b/go.mod index 7721095ba3..5f8e8cdecc 100644 --- a/go.mod +++ b/go.mod @@ -9,8 +9,8 @@ require ( github.com/FZambia/statik v0.1.2-0.20180217151304-b9f012bb2a1b github.com/FZambia/tarantool v0.3.1 github.com/FZambia/viper-lite v0.0.0-20220110144934-1899f66c7d0e - github.com/centrifugal/centrifuge v0.28.0-rc.2 - github.com/centrifugal/protocol v0.9.1-0.20221229170909-b599c453f37f + github.com/centrifugal/centrifuge v0.28.0-rc.3 + github.com/centrifugal/protocol v0.9.1 github.com/cristalhq/jwt/v4 v4.0.2 github.com/gobwas/glob v0.2.3 github.com/google/uuid v1.3.0 diff --git a/go.sum b/go.sum index 9b4505536c..90dfff08ea 100644 --- a/go.sum +++ b/go.sum @@ -16,10 +16,10 @@ github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973/go.mod h1:Dwedo/Wpr24 github.com/beorn7/perks v1.0.0/go.mod h1:KWe93zE9D1o94FZ5RNwFwVgaQK1VOXiVxmqh+CedLV8= github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM= github.com/beorn7/perks v1.0.1/go.mod h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw= -github.com/centrifugal/centrifuge v0.28.0-rc.2 h1:j7hRuahihKtFzL/paX4RCHSvr+sN036R0drR/NBTkgA= -github.com/centrifugal/centrifuge v0.28.0-rc.2/go.mod h1:hcFbuUTu8BV9olwhgRm96cyimdWTUIsFTI0MTSCQtDI= -github.com/centrifugal/protocol v0.9.1-0.20221229170909-b599c453f37f h1:i4aTRwTwBVI0FawuU1R07mxTez3LyBFy6xc0XR/nucU= -github.com/centrifugal/protocol v0.9.1-0.20221229170909-b599c453f37f/go.mod h1:qpYrxz4cDj+rlgC6giSADkf7XDN1K7aFmkkFwt/bayQ= +github.com/centrifugal/centrifuge v0.28.0-rc.3 h1:3qhQsQlUDZBdjDEPvbLJ6pRDoms2oX8b4NeKVSvS4ss= +github.com/centrifugal/centrifuge v0.28.0-rc.3/go.mod h1:zpQcYiUafsDFp7/GF+pKx35gFbAPqJQuzakjH03e8Pg= +github.com/centrifugal/protocol v0.9.1 h1:DCoZvYtblUotGrM7GrpIvKtZYhjT03chvhEN9tyWZMY= +github.com/centrifugal/protocol v0.9.1/go.mod h1:qpYrxz4cDj+rlgC6giSADkf7XDN1K7aFmkkFwt/bayQ= github.com/cespare/xxhash v1.1.0/go.mod h1:XrSqR1VqqWfGrhpAt58auRo0WTKS1nRRg3ghfAqPWnc= github.com/cespare/xxhash/v2 v2.2.0 h1:DC2CZ1Ep5Y4k3ZQ899DldepgrayRUGE6BBZ/cd9Cj44= github.com/cespare/xxhash/v2 v2.2.0/go.mod h1:VGX0DQ3Q6kWi7AoAeZDth3/j3BFtOZR5XLFGgcrjCOs= diff --git a/misc/release/notes.md b/misc/release/notes.md index 327a97425e..9cfbb3ac4a 100644 --- a/misc/release/notes.md +++ b/misc/release/notes.md @@ -8,17 +8,6 @@ For details, go to the [Centrifugo documentation site](https://centrifugal.dev). ## Release notes -### Improvements - -* Possibility to disable client protocol v1 using `disable_client_protocol_v1` boolean option. To remind you about client protocol v1 vs v2 migration in Centrifugo v4 take a look at [v3 to v4 migration guide](https://centrifugal.dev/docs/getting-started/migration_v4#client-sdk-migration). Centrifugo v4 uses client protocol v2 by default, all our recent SDKs only support client protocol v2. So if you are using modern stack then you can disable clients to use outdated protocol v1 right now. In Centrifugo v5 support for client protocol v1 will be completely removed, see [Centrifugo v5 roadmap](https://github.com/centrifugal/centrifugo/issues/599). -* New boolean option `disallow_anonymous_connection_tokens`. When the option is set Centrifugo won't accept connections from anonymous users even if they provided a valid JWT. See [#591](https://github.com/centrifugal/centrifugo/issues/591) -* New option `client_connection_rate_limit` to limit the number of new real-time connections Centrifugo may accept per second, see [docs](https://centrifugal.dev/docs/server/configuration#client_connection_rate_limit) -* Implement `sub_refresh` proxy to periodically validate expiring subscriptions over the call from Centrifugo to the backend endpoint, see [#592](https://github.com/centrifugal/centrifugo/issues/592) and [docs](https://centrifugal.dev/docs/server/proxy#sub-refresh-proxy) -* More human-readable tracing logging output (especially in Protobuf protocol case). On the other hand, tracing log level is much more expensive now. We never assumed it will be used in production – so seems an acceptable trade-off. -* Several internal optimizations in client protocol to reduce memory allocations. -* More strict client protocol: only allow one pong message from client to server after receiving ping, disable sending commands over the connection which returned an error to the Connect command - ### Fixes -* Fix: slow down subscription dissolver workers while Redis PUB/SUB is unavailable. This solves a CPU usage spike which may happen while Redis PUB/SUB is unavailable and last client unsubscribes from some channel. -* Relative static paths in Centrifugo admin web UI (to fix work behind reverse proxy on sub-path) +* Fix decoding of large protocol messages. The bug was introduced by v4.1.1. See [bug report](https://github.com/centrifugal/centrifugo/issues/603)