Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

Clarify date parameter's meaning #1006

Closed
wants to merge 1 commit into from

Conversation

airandfingers
Copy link

Description

Add some text to clarify that specifying a date parameter for a Procedure.search call filters based on the procedure's performed time, not its lastUpdated time.

Fixes #1005

PR Checklist

  • Screenshot(s) of changes attached before changes merged.
image
  • Screenshot(s) of changes attached after changes merged and published.

Not sure how to generate this screenshot. Happy to provide one if doing so is a hard requirement!

@kckeim
Copy link
Contributor

kckeim commented Oct 20, 2023

@airandfingers - what would you like to do here?
We can either run your Pull Request separately ahead of our comprehensive review from the Oracle Health side, or we can roll up your request into what we're changing when we get around to working on the Procedure Resource.
That review is currently staged to start on 12/5/23.

@amcginn / @RicardoCrespo-ora
We'll want to include this change when we get to reviewing/updating/migrating the Procedure documentation if it's not getting dealt with ahead of time (DEVEX-7396 over in JIRA2)

@amcginn
Copy link
Member

amcginn commented Oct 20, 2023

@airandfingers, can you spin up [1] the site locally with this change and post the screenshot with the changes?

[1] https://github.com/cerner/fhir.cerner.com#viewing-documentation-locally

@@ -57,7 +57,7 @@ Search for Procedures that meet supplied query parameters:
`_id` | This or `patient` or `subject` | [`token`] | The logical resource id associated with the resource.
`patient` | This or `_id` or `subject` | [`reference`] | Who the procedure is for. Example: `12345`
`subject` | This or `_id` or `patient` | [`reference`] | Who the procedure is for. Example: `Patient/12345`
`date` | No | [`dateTime`] | Date range into which the procedure falls. Example: `date=gt2015-09-24T12:00:00.000Z&date=le2020-07-15T16:00:00.000Z`
`date` | No | [`dateTime`] | Date range in which the procedure was performed. Example: `date=gt2015-09-24T12:00:00.000Z&date=le2020-07-15T16:00:00.000Z`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be even more specific and call out Procedure.performed

@kckeim, we should probably also add a note in the below section about how this is handled when the Procedure has a period. this part can be done in our more thorough review coming up

@airandfingers
Copy link
Author

@airandfingers, can you spin up [1] the site locally with this change and post the screenshot with the changes?

[1] https://github.com/cerner/fhir.cerner.com#viewing-documentation-locally

Thanks for the link! Unfortunately, after updating ruby and bundler per the error messages output when I tried to run bundle install, I now get this error:

/opt/homebrew/lib/ruby/gems/3.2.0/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:272:in `search_up': undefined method `untaint' for "/~/fhir.cerner.com":String (NoMethodError)

Is a screenshot really necessary for a simple text change?

@amcginn amcginn added the R4 Applies to R4 FHIR resources label Oct 26, 2023
@airandfingers
Copy link
Author

Covered by changes to #1016, thanks!

@airandfingers airandfingers deleted the patch-1 branch February 16, 2024 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
R4 Applies to R4 FHIR resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify whether Procedure.search's date parameter filters based on performed lastUpdated
3 participants