Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: spacing around Files section #3600

Closed
tiborsimko opened this issue Mar 11, 2024 · 2 comments · Fixed by cernopendata/cernopendata-portal#93
Closed

templates: spacing around Files section #3600

tiborsimko opened this issue Mar 11, 2024 · 2 comments · Fixed by cernopendata/cernopendata-portal#93
Assignees

Comments

@tiborsimko
Copy link
Member

Records having directly attached files are not featuring enough spacing before the Files section heading, for example see https://opendata.cern.ch/record/7088

Note also the the Files heading is printed as "h3", whilst the other headings as "h2" usually on that page. Note also that "h3" is apparently printed in a bigger font than "h2", whilst it should usually be the other way round.

An easy solution could be to switch Files heading to "h3", and to rebalance the font sizes for h1/h2/h3 headings, however it may be good to profit from the occasion to more generally check the spacing before/after headings of each section displayed on the detailed record page. Perhaps we may have another field of this kind.

files

@psaiz
Copy link
Contributor

psaiz commented Nov 29, 2024

Reopening the ticket that was automatically closed with the PR

@psaiz psaiz reopened this Nov 29, 2024
@psaiz
Copy link
Contributor

psaiz commented Dec 12, 2024

Deployed in prod. Closing

@psaiz psaiz closed this as completed Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants