Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate trust namespace value as template #291

Open
heruan opened this issue Feb 15, 2024 · 2 comments
Open

Evaluate trust namespace value as template #291

heruan opened this issue Feb 15, 2024 · 2 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@heruan
Copy link

heruan commented Feb 15, 2024

When installing trust-manager as a subchart (i.e. dependency) it would be useful to automatically set the trust namespace value to the release namespace, or another dynamic value. At the moment this is unfortunately not possibile since the app.trust.namespace value is evaluated as-is and so it needs to be always explicitly specified if you don't want the default one.

This can be easily solved if the value were evaluated as a template, e.g.

 metadata:
   name: {{ include "trust-manager.name" . }}
-  namespace: {{ .Values.app.trust.namespace }}
+  namespace: {{ tpl .Values.app.trust.namespace . }}

Then it would be possibile to set the trust namespace dynamically, e.g.

# Subchart configuration when trust-manager is a dependency
trust-manager:
  app:
    trust:
      namespace: {{ .Release.Namespace }}

Is this something that might be worth a PR? I'd be happy to contribute!

@inteon inteon added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Aug 29, 2024
@inteon
Copy link
Member

inteon commented Aug 29, 2024

Alternatively, we might add a special value/ additional option to make it match the release namespace. I think that there are probably only a limited set of values that we would like to create templates for, so maybe templating is overkill and might introduce unexpected problems/ security issues.

@cert-manager-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale

@cert-manager-prow cert-manager-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

3 participants