-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend DRY support into trust-manager official Helm chart #496
base: main
Are you sure you want to change the base?
Extend DRY support into trust-manager official Helm chart #496
Conversation
Asif-git03
commented
Dec 2, 2024
•
edited
Loading
edited
- This PR introduces tpl support for app.webhook.tls.approverPolicy.certManagerNamespace and app.trust.namespace
- the changes allow these values to be dynamically set using helm templating, if not provided ,they default to the release namespace
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Asif-git03. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Khan <[email protected]>
Signed-off-by: Khan <[email protected]>
…-by: Asif Khan <[email protected]> Signed-off-by: Khan <[email protected]>
Signed-off-by: Khan <[email protected]>
98720ba
to
87ef014
Compare
Hi Team, Request you to please review the PR, since the DCO signoff: yes |
Hi Team, Could you please check on this PR once |
Hi Team, Request you to please review the PR, since the DCO signoff: yes |
@Asif-git03 trust-manager is a community project and maintainers/reviewers all have day-time jobs. So please don't expect reviews when you request it. And no point "spamming". 😓 I am personally not in favor of your proposed changes. What is the use case? And how is it related to DRY? It definitely increases complexity by adding a second layer of templating. Trying to understand what your goal is, but no luck so far..... |