Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend DRY support into trust-manager official Helm chart #496

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Asif-git03
Copy link

@Asif-git03 Asif-git03 commented Dec 2, 2024

  • This PR introduces tpl support for app.webhook.tls.approverPolicy.certManagerNamespace and app.trust.namespace
  • the changes allow these values to be dynamically set using helm templating, if not provided ,they default to the release namespace

@cert-manager-prow cert-manager-prow bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Dec 2, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sgtcodfish for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 2, 2024
@cert-manager-prow
Copy link
Contributor

Hi @Asif-git03. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 2, 2024
@Asif-git03 Asif-git03 force-pushed the feature/extend-dry-support-trust-manager-tpl branch from 98720ba to 87ef014 Compare December 3, 2024 06:42
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Dec 3, 2024
@Asif-git03
Copy link
Author

Hi Team,

Request you to please review the PR, since the DCO signoff: yes

@Asif-git03
Copy link
Author

Hi Team,

Could you please check on this PR once

@Asif-git03
Copy link
Author

Hi Team,

Request you to please review the PR, since the DCO signoff: yes

@erikgb
Copy link
Contributor

erikgb commented Dec 10, 2024

@Asif-git03 trust-manager is a community project and maintainers/reviewers all have day-time jobs. So please don't expect reviews when you request it. And no point "spamming". 😓

I am personally not in favor of your proposed changes. What is the use case? And how is it related to DRY? It definitely increases complexity by adding a second layer of templating. Trying to understand what your goal is, but no luck so far.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants