Skip to content

Commit ce4be90

Browse files
committed
Upgrade to Spring 5.2.0.RC1, Spring Boot 2.2.0.M5, Reactor Core 3.3.0.M3 and Reactor Netty 0.9.0.M3
* also upgrade Gradle Git Properties and Versions plugins to latest * finally support AppDetail#buildpackVersion
1 parent 7a2f7e7 commit ce4be90

File tree

4 files changed

+13
-11
lines changed

4 files changed

+13
-11
lines changed

build.gradle

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
plugins {
2-
id 'com.gorylenko.gradle-git-properties' version '2.0.0'
3-
id 'org.springframework.boot' version '2.2.0.M4'
2+
id 'com.gorylenko.gradle-git-properties' version '2.1.0'
3+
id 'org.springframework.boot' version '2.2.0.M5'
44
id 'io.spring.dependency-management' version '1.0.8.RELEASE'
5-
id 'com.github.ben-manes.versions' version '0.21.0'
5+
id 'com.github.ben-manes.versions' version '0.22.0'
66
id 'io.franzbecker.gradle-lombok' version '3.1.0'
77
id 'java'
88
id 'jacoco'
@@ -58,7 +58,7 @@ ext {
5858
set('springCloudServicesVersion', '2.1.4.RELEASE')
5959
set('springCloudVersion', 'Hoxton.M1')
6060
set('spring-cloud-services-connectors.version', '2.1.4.RELEASE')
61-
set('spring-framework.version', '5.2.0.BUILD-SNAPSHOT')
61+
set('spring-framework.version', '5.2.0.RC1')
6262
}
6363

6464
dependencyManagement {
@@ -112,8 +112,8 @@ dependencies {
112112
implementation('io.pivotal.spring.cloud:spring-cloud-services-starter-config-client')
113113
implementation('io.pivotal.spring.cloud:spring-cloud-services-starter-service-registry')
114114
implementation('org.springframework.boot:spring-boot-starter-log4j2')
115-
implementation('io.projectreactor:reactor-core:3.3.0.M1')
116-
implementation('io.projectreactor.netty:reactor-netty:0.9.0.M2')
115+
implementation('io.projectreactor:reactor-core:3.3.0.M3')
116+
implementation('io.projectreactor.netty:reactor-netty:0.9.0.M3')
117117
implementation('io.micrometer:micrometer-registry-prometheus')
118118
testImplementation('io.projectreactor:reactor-test')
119119
testImplementation('org.junit.jupiter:junit-jupiter-api')

src/main/java/io/pivotal/cfapp/domain/AppDetail.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ public class AppDetail {
3030
private String appId;
3131
private String appName;
3232
private String buildpack;
33+
private String buildpackVersion;
3334
private String image;
3435
private String stack;
3536
@Default
@@ -50,7 +51,7 @@ public class AppDetail {
5051

5152
public String toCsv() {
5253
return String.join(",", wrap(getFoundation()), wrap(getOrganization()), wrap(getSpace()), wrap(getAppId()), wrap(getAppName()),
53-
wrap(getBuildpack()), wrap(getImage()), wrap(getStack()), wrap(String.valueOf(getRunningInstances())),
54+
wrap(getBuildpack()), wrap(getBuildpackVersion()), wrap(getImage()), wrap(getStack()), wrap(String.valueOf(getRunningInstances())),
5455
wrap(String.valueOf(getTotalInstances())), wrap(Double.toString(toGigabytes(getMemoryUsage()))),
5556
wrap(Double.toString(toGigabytes(getDiskUsage()))),
5657
(wrap(String.join(",", getUrls() != null ? getUrls(): Collections.emptyList()))),
@@ -59,7 +60,7 @@ public String toCsv() {
5960
wrap(getRequestedState()));
6061
}
6162

62-
private String wrap(String value) {
63+
private static String wrap(String value) {
6364
return value != null ? StringUtils.wrap(value, '"') : StringUtils.wrap("", '"');
6465
}
6566

@@ -68,7 +69,7 @@ private Double toGigabytes(Long input) {
6869
}
6970

7071
public static String headers() {
71-
return String.join(",", "foundation", "organization", "space", "application id", "application name", "buildpack", "image",
72+
return String.join(",", "foundation", "organization", "space", "application id", "application name", "buildpack", "buildpack version", "image",
7273
"stack", "running instances", "total instances", "memory used (in gb)", "disk used (in gb)", "urls", "last pushed", "last event",
7374
"last event actor", "last event time", "requested state");
7475
}
@@ -82,6 +83,7 @@ public static AppDetailBuilder from(AppDetail detail) {
8283
.appId(detail.getAppId())
8384
.appName(detail.getAppName())
8485
.buildpack(detail.getBuildpack())
86+
.buildpackVersion(detail.getBuildpackVersion())
8587
.image(detail.getImage())
8688
.stack(detail.getStack())
8789
.runningInstances(detail.getRunningInstances())

src/main/java/io/pivotal/cfapp/domain/AppRelationship.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public String toCsv() {
3333
wrap(getServiceInstanceId()), wrap(getServiceName()), wrap(getServicePlan()), wrap(getServiceType()));
3434
}
3535

36-
private String wrap(String value) {
36+
private static String wrap(String value) {
3737
return value != null ? StringUtils.wrap(value, '"') : StringUtils.wrap("", '"');
3838
}
3939

src/main/java/io/pivotal/cfapp/domain/ServiceInstanceDetail.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public String toCsv() {
4848
wrap(getRequestedState()));
4949
}
5050

51-
private String wrap(String value) {
51+
private static String wrap(String value) {
5252
return value != null ? StringUtils.wrap(value, '"') : StringUtils.wrap("", '"');
5353
}
5454

0 commit comments

Comments
 (0)