From 16dee128152137fd04bdcaa5a693188e2bf2b956 Mon Sep 17 00:00:00 2001 From: Brett Moore Date: Wed, 29 Oct 2025 14:50:43 -0600 Subject: [PATCH 1/3] [CFFDRS R Bug]: Select results in a name error in fbpRaster Fixes #60 --- R/fbpRaster.r | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/R/fbpRaster.r b/R/fbpRaster.r index 3c68035..6718971 100644 --- a/R/fbpRaster.r +++ b/R/fbpRaster.r @@ -426,7 +426,8 @@ fbpRaster <- function( names(out) <- select # FBP <- FBP[, ..select] for (i in select) { - out[[i]] <- FBP[[i]] + new <- setValues(out[i],FBP[i]) + out[[i]] <- new } return(out) } From e28a18cca7c2fbabcffb9fd2e2cb19db31500128 Mon Sep 17 00:00:00 2001 From: Brett Moore Date: Wed, 29 Oct 2025 15:03:40 -0600 Subject: [PATCH 2/3] Adjustment to ensure tests in example functioned. --- R/fbpRaster.r | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/fbpRaster.r b/R/fbpRaster.r index 6718971..6019b0b 100644 --- a/R/fbpRaster.r +++ b/R/fbpRaster.r @@ -426,7 +426,7 @@ fbpRaster <- function( names(out) <- select # FBP <- FBP[, ..select] for (i in select) { - new <- setValues(out[i],FBP[i]) + new <- setValues(out[[i]],FBP[i]) out[[i]] <- new } return(out) From 128db91798522f5569195d95b198fb0a2290c6b6 Mon Sep 17 00:00:00 2001 From: Brett Moore Date: Wed, 29 Oct 2025 15:05:13 -0600 Subject: [PATCH 3/3] Further simplification of the solution. --- R/fbpRaster.r | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/R/fbpRaster.r b/R/fbpRaster.r index 6019b0b..ae23556 100644 --- a/R/fbpRaster.r +++ b/R/fbpRaster.r @@ -426,8 +426,7 @@ fbpRaster <- function( names(out) <- select # FBP <- FBP[, ..select] for (i in select) { - new <- setValues(out[[i]],FBP[i]) - out[[i]] <- new + out[[i]] <- setValues(out[[i]],FBP[i]) } return(out) }