Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect specification feedback #2

Open
cfl0ws opened this issue Oct 16, 2019 · 9 comments
Open

Collect specification feedback #2

cfl0ws opened this issue Oct 16, 2019 · 9 comments

Comments

@cfl0ws
Copy link
Owner

cfl0ws commented Oct 16, 2019

The initial requirements specification draft can be found here. See the "MVP" tab, as that's the spec I'll start with.

Please provide feedback in the comments of this issue 👇or as comments in the Google Sheet.

Note: The current draft focuses on fault, configuration and performance monitoring and alerting. Additional security monitoring and alerting requirements will be added next.

@cfl0ws
Copy link
Owner Author

cfl0ws commented Nov 19, 2019

Thanks @jackzampolin for your feedback in the doc and via Telegram. In addition to the comment you suggested in the doc, I'll add your Telegram feedback here for reference -

"Only thing I would add there is additional metrics around HSM integration with

https://github.com/tendermint/signatory

But that list looks great."

I'll take a look at the HSM metrics and add some too 👍

@anilcse
Copy link
Collaborator

anilcse commented Nov 19, 2019

How about alerts on following events:

  • On new proposal
  • On proposal voting deadlines (if not voted)
  • On propsal result

@novy4
Copy link

novy4 commented Nov 20, 2019

I added a comment to the sheet about validator's reward indicator. Maybe it would be useful to get this data as well.

@liangping
Copy link

We need a dashboard to watch those data from all sentries and validator(in public/private network).

@cfl0ws
Copy link
Owner Author

cfl0ws commented Jan 7, 2020

@anilcse I added your suggestions. Please check rows 58-61 to see if they convey what you had in mind. I'm debating whether these will be in the MVP or added at a later stage, i.e. MVP Plus. I added them to the MVP for now, to see if we can implement them. I agree these would be very beneficial!

@cfl0ws
Copy link
Owner Author

cfl0ws commented Jan 7, 2020

@novy4 Are you referring to all unclaimed/unwithdrawn rewards, as described here?

@cfl0ws
Copy link
Owner Author

cfl0ws commented Jan 7, 2020

@liangping Can you please clarify specifically what data you mean? Are you referring to the connections among sentries and validators, to confirm they're communicating with each other?

@cfl0ws
Copy link
Owner Author

cfl0ws commented Jan 7, 2020

@jackzampolin are there any specific metrics you feel would be beneficial related to this?

https://docs.cosmos.network/master/modules/distribution/04_messages.html#msgwithdrawdelegationrewardsall

I'm going to add these to the MVP Plus sheet for now. My thinking is that this tool will probably be used most by smaller validator operators at first and they're unlikely to be using HSMs.

@novy4
Copy link

novy4 commented Jan 7, 2020

@novy4 Are you referring to all unclaimed/unwithdrawn rewards, as described here?

I was referring to voting power or validator address staking total probably...

Repository owner deleted a comment from jalamari2018 Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants