Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect: refactor drop-down transition to issue proper event states #1182

Open
anselmbradford opened this issue Feb 3, 2021 · 1 comment

Comments

@anselmbradford
Copy link
Member

Describe the bug
The search input opens when the search input gets focus and closes when it's blurred. Focus happens on mousedown, so it gets the attributes of being open when it is clicked, not when the drop-down has actually completed opening. We should re-write this to dispatch events for the life cycle of the drop-down expand (expandBegin, transitionBegin, transitionEnd, expandEnd) and (collapseBegin, transitionBegin, transitionEnd, collapseEnd). The attributes of the drop-down being open should be added at the end of the expandEnd sequence and removed at the beginning of the collapseBegin sequence. Currently, the collapse method (erroneously) dispatches the expandEnd event.

@sonnakim
Copy link
Member

We talked about making the multiselect a web component, this could be addressed as part of that work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants