Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio buttons - Define state styling (Success/Warning/Error status) #1890

Open
shindigira opened this issue Jan 22, 2024 · 4 comments
Open

Comments

@shindigira
Copy link
Contributor

shindigira commented Jan 22, 2024

@anselmbradford @sonnakim

Overview

The purpose of this issue is to capture the work needed to extend the enhancements we're making to checkboxes to radio buttons with the goal of keeping these two related components in sync. Currently radio buttons do not include state styling for status (Success, Warning, Error).

  • Apply status styling to radio buttons (Success, Warning, Error)
  • Scope of work includes Default and Focus states (hover will be handled in a future PR)
  • Styling aligns with text inputs

--

Related PR

@natalia-fitzgerald natalia-fitzgerald changed the title RadioButton - Define state styling (Success/Warning/Error status) Radio buttons - Define state styling (Success/Warning/Error status) Jan 22, 2024
@sonnakim
Copy link
Member

Hey @shindigira — just to confirm, it looks like checkboxes were worked on but not radio buttons (the subject of this issue), is that right?

@sonnakim
Copy link
Member

sonnakim commented Oct 1, 2024

Chris will post in the SBL Mattermost channel to follow up.

@sonnakim
Copy link
Member

sonnakim commented Oct 1, 2024

@contolini (sorry should have tagged you!)

@shindigira
Copy link
Contributor Author

shindigira commented Oct 1, 2024

Hey @shindigira — just to confirm, it looks like checkboxes were worked on but not radio buttons (the subject of this issue), is that right?

@sonnakim
Apologies for not responding to this. That is correct.

I believe @natalia-fitzgerald wanted to provide the goal of aligning all the input elements (e.g. checkboxes, radios, selects, form inputs) styling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants