Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove path module and join relevant functions to auxiliaries.ts #110

Closed
anne-gropler opened this issue Oct 11, 2018 · 1 comment
Closed

remove path module and join relevant functions to auxiliaries.ts #110

anne-gropler opened this issue Oct 11, 2018 · 1 comment
Assignees
@cgcostume
Projects
webgl-operate 1.0.0
Milestone
july.plan

Comments

@anne-gropler
Copy link
Collaborator

anne-gropler commented Oct 11, 2018 •
edited
Loading

The path module increases bundle size, but only a few functions are used in fontloader.ts.

As @bwasty said in PR #73

the related commit actually increases the whole bundle size by 3.5KB (parsed) / 1.4KB (gzipped)
(tested with npm run analyze)
@anne-gropler anne-gropler mentioned this issue Oct 11, 2018
Merged
@cgcostume cgcostume added this to To do in webgl-operate 1.0.0 Oct 12, 2018
@cgcostume cgcostume moved this from To Do, not Started to In Progress in webgl-operate 1.0.0 Mar 7, 2019
cgcostume added a commit that referenced this issue Mar 8, 2019
@cgcostume
#110 remove use of nodejs path, tweak example
a08dbc3
@cgcostume cgcostume moved this from In Progress to PO Sign-Off in webgl-operate 1.0.0 Mar 8, 2019
cgcostume added a commit that referenced this issue Mar 8, 2019
@cgcostume
Merge pull request #168 from cginternals/remove-path-110
f328bca 
#110 remove use of nodejs path, tweak example
@cgcostume cgcostume moved this from PO Sign-Off to Done in webgl-operate 1.0.0 Mar 8, 2019
@anne-gropler anne-gropler mentioned this issue Mar 14, 2019
Closed
@cgcostume cgcostume changed the title remove path node.js module and join relevant functions to auxiliaries.ts remove path module and join relevant functions to auxiliaries.ts Jul 3, 2019
@cgcostume cgcostume added this to the july.plan milestone Jul 3, 2019
@cgcostume cgcostume self-assigned this Jul 3, 2019
@cgcostume
Copy link
Member

seems to be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgcostume cgcostume

Labels
None yet
Projects
webgl-operate 1.0.0
  
Done
Milestone
july.plan
Development

No branches or pull requests
2 participants
@cgcostume @anne-gropler