Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge_neighbors() does not work with datetime objects #115

Open
murrple-1 opened this issue Mar 21, 2022 · 1 comment
Open

merge_neighbors() does not work with datetime objects #115

murrple-1 opened this issue Mar 21, 2022 · 1 comment

Comments

@murrple-1
Copy link

Due to this line:

margin = higher.begin - lower.end

__sub__() is not defined for dateime.datetime, dateime.time or dateime.date objects, though they work in most (all?) other contexts, and seem to be "supported".

@murrple-1
Copy link
Author

murrple-1 commented Mar 21, 2022

Proposing that the function have an optional parameter like:

...
margin_fn=lambda begin, end: begin - end,
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant