Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After adding "evm" configuration, gas fee estimation is wrong #1089

Open
zakir-code opened this issue Apr 2, 2024 · 1 comment · Fixed by #1091
Open

After adding "evm" configuration, gas fee estimation is wrong #1089

zakir-code opened this issue Apr 2, 2024 · 1 comment · Fixed by #1091
Labels
bug Something isn't working keplr-extension This is for keplr browser extension

Comments

@zakir-code
Copy link

Describe the bug

If the evm configuration is set, eip1559 will be used first to calculate the handling fee. However, the cosmos transaction fee is calculated according to minimum-gas-prices. The gas prices in the two places may not be the same. If minimum-gas-prices is larger and always fails when sending transactions using keplr.

if (this.canEIP1559TxFeesAndReady()) {
const { maxFeePerGas } = this.getEIP1559TxFees(feeType);
return maxFeePerGas;
}
// TODO: Handle terra classic fee
return this.populateGasPriceStep(feeCurrency, feeType);

Expected behavior

I wonder if I can add configuration in evm, such as enable_eip1559, or compare the final calculation results of the two, and use the larger one first.

@zakir-code zakir-code added bug Something isn't working keplr-extension This is for keplr browser extension labels Apr 2, 2024
@delivan
Copy link
Member

delivan commented Apr 2, 2024

Hi @zakir-code

Our intention is that if the user enters a bech32 address on the send page, the transaction fee should be calculated by Cosmos way, and if the user enters a hex address, it should be calculated by EIP-1559 way. But currently gas estimation works as intended, but gas price doesn't work like that as you said. Thanks for letting us know. We will fix it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working keplr-extension This is for keplr browser extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants