fix(integration): do not fail if can't delete associate credentials (#187)

migmartri · web-flow · commit 6beb8799bd13 · 2023-06-19T13:36:06.000+02:00
Signed-off-by: Miguel Martinez Trivino &lt;miguel@chainloop.dev&gt;
diff --git a/app/controlplane/internal/biz/integration.go b/app/controlplane/internal/biz/integration.go
@@ -270,7 +270,7 @@ func (uc *IntegrationUseCase) Delete(ctx context.Context, orgID, integrationID s
 	if integration.SecretName != "" {
 		uc.logger.Infow("msg", "deleting integration external secrets", "ID", integrationID, "secretName", integration.SecretName)
 		if err := uc.credsRW.DeleteCredentials(ctx, integration.SecretName); err != nil {
-			return fmt.Errorf("deleting the credentials: %w", err)
+			uc.logger.Warnw("msg", "can't delete credentials", "name", integration.SecretName, "err", err)
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -270,7 +270,7 @@ func (uc *IntegrationUseCase) Delete(ctx context.Context, orgID, integrationID s`
`270`	`270`	`if integration.SecretName != "" {`
`271`	`271`	`uc.logger.Infow("msg", "deleting integration external secrets", "ID", integrationID, "secretName", integration.SecretName)`
`272`	`272`	`if err := uc.credsRW.DeleteCredentials(ctx, integration.SecretName); err != nil {`
`273`		`- return fmt.Errorf("deleting the credentials: %w", err)`
	`273`	`+ uc.logger.Warnw("msg", "can't delete credentials", "name", integration.SecretName, "err", err)`
`274`	`274`	`}`
`275`	`275`	`}`
`276`	`276`