Analysis of `jNorm` failed canonicalizations

[algomaster99]

Successful canonicalization: 267
Failed canonicalization: 478
Error in canonicalization: 153

We analyze the 478 here.

What jNorm fails at

1. order of declaration of methods in interface
2. order of declaration of if-else
3. order of declaration of static blocks
4. order of values in annotation
5. Non deterministic generation of code
6. return type change
7. cannot normalize invokeinterface is changed to invokevirtual
8. switch is created using a synthetic class
9. condition change from == to != (control)
10. hardcoded paths
11. invokedynamic and String.valueOf
12. try and try with resource
13. jsr and ret
14. changes in visibility of fields.
15. relocations done by maven-shade-plugin
16. names of lambda functions
17. Unable to normalize this$0
18. does not have module-info.class
19. surprising normalises BUILD_DATE

Order

1. order of declaration of methods in interface
2. order of declaration of if-else
3. order of declaration of static blocks
4. order of values in annotation

Optimizations

1. cannot normalize invokeinterface is changed to invokevirtual
2. switch is created using a synthetic class
3. invokedynamic and String.valueOf
4. try and try with resource
5. jsr and ret
6. Unable to normalize this$0

Refactoring

1. relocations done by maven-shade-plugin
2. names of lambda functions
3. condition change from == to != (control)
4. hardcoded paths
5. changes in visibility of fields.

Mystery

1. does not have module-info.class (empties the class)
2. surprising normalises BUILD_DATE (this is because it does not store the value of public static final java.lang.String BUILD_DATE;)
3. Non deterministic generation of code
4. return type change

[algomaster99]

Unable to normalize order of declaration of methods in interface and if else-if blocks in io.fabric8:kubernetes-client-project:6.4.0 - #6 (comment)

In RC - https://github.com/jvm-repo-rebuild/reproducible-central/blob/b26baa6bfd76e6f863f1b32022bf03925ce43dba/content/io/fabric8/kubernetes-client/kubernetes-client-project-6.4.0.diffoscope#L3

[algomaster99]

Unable to normalize order of values in annotation - #6 (comment) org.apache.activemq:activemq-parent:5.16.6

[algomaster99]

The class has changed #6 (comment) org.apache.isis:isis-parent:2.0.0-M7

[algomaster99]

#6 (comment)

tech.picnic.error-prone-support:error-prone-support:0.15.0

• one more element in getRecipeList
• lamda functions have different numbers

[algomaster99]

#6 (comment)

Unable to normalize the flip() method in from-repairnator/org.apache.dubbo/dubbo/2.7.12/dubbo-remoting-api-2.7.12.jar.diffoscope.json

[algomaster99]

dev.langchain4j:langchain4j-elasticsearch:0.28.0

There seems to be a change in how getClass is invoked. This is not canonicalized by jNorm. This also happens for equals and toString in langchain4j-0.28.0.jar.

diff -u results/dev.langchain4j/langchain4j/0.28.0/jnorm/reference/langchain4j-elasticsearch-0.28.0.jar:langchain4j-elasticsearch-0.28.0.jar/dev.langchain4j.store.embedding.elasticsearch.ElasticsearchMetadataFilterMapper.jimple results/dev.langchain4j/langchain4j/0.28.0/jnorm/rebuild/langchain4j-elasticsearch-0.28.0.jar:langchain4j-elasticsearch-0.28.0.jar/dev.langchain4j.store.embedding.elasticsearch.ElasticsearchMetadataFilterMapper.jimple
--- results/dev.langchain4j/langchain4j/0.28.0/jnorm/reference/langchain4j-elasticsearch-0.28.0.jar:langchain4j-elasticsearch-0.28.0.jar/dev.langchain4j.store.embedding.elasticsearch.ElasticsearchMetadataFilterMapper.jimple	2025-03-12 18:07:00.562413059 +0000
+++ results/dev.langchain4j/langchain4j/0.28.0/jnorm/rebuild/langchain4j-elasticsearch-0.28.0.jar:langchain4j-elasticsearch-0.28.0.jar/dev.langchain4j.store.embedding.elasticsearch.ElasticsearchMetadataFilterMapper.jimple	2025-03-12 18:07:07.690300949 +0000
@@ -72,7 +72,7 @@
 return v;
 label:
 v = new java.lang.UnsupportedOperationException;
-v = interfaceinvoke v.<dev.langchain4j.store.embedding.filter.Filter: java.lang.Class getClass()>();
+v = virtualinvoke v.<java.lang.Object: java.lang.Class getClass()>();
 v = virtualinvoke v.<java.lang.Class: java.lang.String getName()>();
 v = dynamicinvoke "makeConcatWithConstants" <java.lang.String (java.lang.String)>(v) <java.lang.invoke.StringConcatFactory: java.lang.invoke.CallSite makeConcatWithConstants(java.lang.invoke.MethodHandles$Lookup,java.lang.String,java.lang.invoke.MethodType,java.lang.String,java.lang.Object[])>("Unsupported filter type: \u0001");
 specialinvoke v.<java.lang.UnsupportedOperationException: void <init>(java.lang.String)>(v);

makeConcatWithConstants MethodHandle is changed

-v = dynamicinvoke "makeConcatWithConstants" <java.lang.String (java.lang.String,java.lang.String,int,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String,long)>(v, v, v, v, v, v, v, v, v, v, v, v) <java.lang.invoke.StringConcatFactory: java.lang.invoke.CallSite makeConcatWithConstants(java.lang.invoke.MethodHandles$Lookup,java.lang.String,java.lang.invoke.MethodType,java.lang.String,java.lang.Object[])>("Neo4jEmbeddingStore.Neo4jEmbeddingStoreBuilder(config=\u, driver=\u, dimension=\u, label=\u, embeddingProperty=\u, idProperty=\u, metadataPrefix=\u, textProperty=\u, indexName=\u, databaseName=\u, retrievalQuery=\u, awaitIndexTimeout=\u)");
+v = dynamicinvoke "makeConcatWithConstants" <java.lang.String (org.neo4j.driver.SessionConfig,org.neo4j.driver.Driver,int,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String,long)>(v, v, v, v, v, v, v, v, v, v, v, v) <java.lang.invoke.StringConcatFactory: java.lang.invoke.CallSite makeConcatWithConstants(java.lang.invoke.MethodHandles$Lookup,java.lang.String,java.lang.invoke.MethodType,java.lang.String,java.lang.Object[])>("Neo4jEmbeddingStore.Neo4jEmbeddingStoreBuilder(config=\u, driver=\u, dimension=\u, label=\u, embeddingProperty=\u, idProperty=\u, metadataPrefix=\u, textProperty=\u, indexName=\u, databaseName=\u, retrievalQuery=\u, awaitIndexTimeout=\u)");

Lists are not converted to Strings in the later version

-v = dynamicinvoke "makeConcatWithConstants" <java.lang.String (java.lang.String,java.lang.String,java.lang.String,java.lang.String,java.lang.String)>(v, v, v, v, v) <java.lang.invoke.StringConcatFactory: java.lang.invoke.CallSite makeConcatWithConstants(java.lang.invoke.MethodHandles$Lookup,java.lang.String,java.lang.invoke.MethodType,java.lang.String,java.lang.Object[])>("LangchainInfinispanItem{id=\'\u0001\', embedding=\u, text=\'\u0001\', metadataKeys=\u, metadataValues=\u0001}");
+v = dynamicinvoke "makeConcatWithConstants" <java.lang.String (java.lang.String,java.lang.String,java.lang.String,java.util.List,java.util.List)>(v, v, v, v, v) <java.lang.invoke.StringConcatFactory: java.lang.invoke.CallSite makeConcatWithConstants(java.lang.invoke.MethodHandles$Lookup,java.lang.String,java.lang.invoke.MethodType,java.lang.String,java.lang.Object[])>("LangchainInfinispanItem{id=\'\u0001\', embedding=\u, text=\'\u0001\', metadataKeys=\u, metadataValues=\u0001}");

[algomaster99]

com.github.ldapchai:ldapchai:0.8.6

Unable to canonicalize both issues - switch-case and inovkeinterface vs invokevirtual #6 (comment).

[algomaster99]

eu.maveniverse.maven.mima:mima:2.4.2

Unable to normalize the if v != 0. See (1. #6 (comment))

1

-return v;
+if v != 0 goto label;
+return 0;
+label:
+return 1;

and 2

-if v != 0 goto label;
-v = 1;
-goto label;
-label:
-v = 0;
+if v == 0 goto label;
+return 0;
 label:
-return v;
+return 1;

and 3 and 4.

[algomaster99]

nl.basjes.parse.useragent:yauaa:7.28.0

Cannot normalize runtime generated code #6 (comment)

[algomaster99]

org.apache.cxf.fediz:fediz:1.6.1

Cannot normalize harcoded paths #6 (comment) which is okay.

-virtualinvoke v.<java.util.logging.Logger: void log(java.util.logging.Level,java.lang.String,java.lang.Object)>(v, "Can not initialize the default wsdl from {0}", "file:/Users/coheigea/src/apache/cxf-fediz/target/checkout/examples/wsclientWebapp/webservice/common/src/main/resources/wsdl/hello_world.wsdl");
+virtualinvoke v.<java.util.logging.Logger: void log(java.util.logging.Level,java.lang.String,java.lang.Object)>(v, "Can not initialize the default wsdl from {0}", "file:/var/maven/app/examples/wsclientWebapp/webservice/common/src/main/resources/wsdl/hello_world.wsdl");

[algomaster99]

org.apache.batchee:batchee:2.0.0

Cannot canonicalize valueOf (see 1. #6 (comment))

[algomaster99]

io.dropwizard.metrics:metrics-servlets:4.1.27

Unable to normalize try to try-with-resource #6 (comment) (2)

[algomaster99]

org.finos.legend.engine:legend-engine:4.56.0

Unable to normalize the differences due to ordering changes

+v = newarray (java.lang.String)[1];
+v[0] = "elementOverride";
+v = virtualinvoke v.<org.finos.legend.pure.runtime.java.compiled.generation.processors.support.coreinstance.ReflectiveCoreInstance$KeyIndexBuilder: org.finos.legend.pure.runtime.java.compiled.generation.processors.support.coreinstance.ReflectiveCoreInstance$KeyIndexBuilder withKeys(java.lang.String,java.lang.String,java.lang.String[])>("Root::meta::pure::metamodel::type::Any", "classifierGenericType", v);
 v = newarray (java.lang.String)[3];
 v[0] = "fileName";
 v[1] = "format";
 v[2] = "message";
 v = virtualinvoke v.<org.finos.legend.pure.runtime.java.compiled.generation.processors.support.coreinstance.ReflectiveCoreInstance$KeyIndexBuilder: org.finos.legend.pure.runtime.java.compiled.generation.processors.support.coreinstance.ReflectiveCoreInstance$KeyIndexBuilder withKeys(java.lang.String,java.lang.String,java.lang.String[])>("Root::meta::pure::generation::metamodel::GenerationOutput", "content", v);
-v = newarray (java.lang.String)[1];
-v[0] = "elementOverride";
-v = virtualinvoke v.<org.finos.legend.pure.runtime.java.compiled.generation.processors.support.coreinstance.ReflectiveCoreInstance$KeyIndexBuilder: org.finos.legend.pure.runtime.java.compiled.generation.processors.support.coreinstance.ReflectiveCoreInstance$KeyIndexBuilder withKeys(java.lang.String,java.lang.String,java.lang.String[])>("Root::meta::pure::metamodel::type::Any", "classifierGenericType", v);

[algomaster99]

fr.vidal.oss:atom-jaxb:1.1.0

Unable to normalize generated code

-public static fr.vidal.oss.jaxb.atom.core.ExtensionElementAdapterTestAssert then(fr.vidal.oss.jaxb.atom.core.ExtensionElementAdapterTest)
-{
-fr.vidal.oss.jaxb.atom.core.ExtensionElementAdapterTest v;
-fr.vidal.oss.jaxb.atom.core.ExtensionElementAdapterTestAssert v;
-v := @parameter: fr.vidal.oss.jaxb.atom.core.ExtensionElementAdapterTest;
-v = new fr.vidal.oss.jaxb.atom.core.ExtensionElementAdapterTestAssert;
-specialinvoke v.<fr.vidal.oss.jaxb.atom.core.ExtensionElementAdapterTestAssert: void <init>(fr.vidal.oss.jaxb.atom.core.ExtensionElementAdapterTest)>(v);
-return v;
-}
-public static fr.vidal.oss.jaxb.atom.core.ExtensionElementTestAssert then(fr.vidal.oss.jaxb.atom.core.ExtensionElementTest)
-{
-fr.vidal.oss.jaxb.atom.core.ExtensionElementTestAssert v;
-fr.vidal.oss.jaxb.atom.core.ExtensionElementTest v;
-v := @parameter: fr.vidal.oss.jaxb.atom.core.ExtensionElementTest;
-v = new fr.vidal.oss.jaxb.atom.core.ExtensionElementTestAssert;
-specialinvoke v.<fr.vidal.oss.jaxb.atom.core.ExtensionElementTestAssert: void <init>(fr.vidal.oss.jaxb.atom.core.ExtensionElementTest)>(v);
-return v;