From 1999d286ab5fe330ec28c8dcbfafc22d745c9db9 Mon Sep 17 00:00:00 2001
From: Andrew King <pepsiotaku@gmail.com>
Date: Sun, 12 Jun 2022 23:22:18 -0400
Subject: [PATCH] link SettingsAction directly with RouteType to clean
 Router::routeSettings(), remove some old code

---
 src/Core/Application.cpp        | 20 --------------------
 src/Core/Application.hpp        |  2 --
 src/Router/Router.cpp           | 21 +--------------------
 src/Settings/SettingsAction.hpp | 12 +++++++-----
 src/Terminal/Output.cpp         | 16 ----------------
 src/Terminal/Output.hpp         |  2 --
 6 files changed, 8 insertions(+), 65 deletions(-)

diff --git a/src/Core/Application.cpp b/src/Core/Application.cpp
index 73b50e837..06fae8d01 100644
--- a/src/Core/Application.cpp
+++ b/src/Core/Application.cpp
@@ -60,9 +60,6 @@ bool Application::handleRoute()
 /*****************************************************************************/
 void Application::initializeTerminal()
 {
-	// Output::resetStdout();
-	// Output::resetStderr();
-
 #if defined(CHALET_WIN32)
 	WindowsTerminal::initialize();
 #endif
@@ -75,7 +72,6 @@ void Application::initializeTerminal()
 		Diagnostic::printErrors();
 		this->cleanup();
 	});
-	testSignalHandling();
 #endif // _DEBUG
 }
 
@@ -107,20 +103,4 @@ void Application::cleanup()
 #endif
 }
 
-/*****************************************************************************/
-void Application::testSignalHandling()
-{
-	// int* test = nullptr;
-	// chalet_assert(test != nullptr, ""); // SIGABRT / abort
-	// int test2 = *test;					// SIGSEGV / segmentation fault
-
-	// int a = 0;
-	// int test2 = 25 / a; // SIGFPE / arithmetic error
-
-	// LOG(test2);
-
-	// ::raise(SIGILL);
-	// ::raise(SIGTERM);
-	// ::raise(SIGABRT); // generic abort
-}
 }
diff --git a/src/Core/Application.hpp b/src/Core/Application.hpp
index c15f04a4c..25d930abc 100644
--- a/src/Core/Application.hpp
+++ b/src/Core/Application.hpp
@@ -31,8 +31,6 @@ class Application
 	int onExit(const Status inStatus);
 	void cleanup();
 
-	void testSignalHandling();
-
 	Unique<CommandLineInputs> m_inputs;
 };
 }
diff --git a/src/Router/Router.cpp b/src/Router/Router.cpp
index 85c3fa22f..a528c6ea4 100644
--- a/src/Router/Router.cpp
+++ b/src/Router/Router.cpp
@@ -217,27 +217,8 @@ bool Router::routeSettings()
 {
 	const auto& route = m_inputs.route();
 
-	SettingsAction action = SettingsAction::Get;
-	switch (route.type())
-	{
-		case RouteType::SettingsSet:
-			action = SettingsAction::Set;
-			break;
-		case RouteType::SettingsGet:
-			action = SettingsAction::Get;
-			break;
-		case RouteType::SettingsUnset:
-			action = SettingsAction::Unset;
-			break;
-		case RouteType::SettingsGetKeys:
-			action = SettingsAction::QueryKeys;
-			break;
-		default:
-			return false;
-	}
-
 	SettingsManager settingsMgr(m_inputs);
-	if (!settingsMgr.run(action))
+	if (!settingsMgr.run(static_cast<SettingsAction>(route.type())))
 		return true;
 
 	return true;
diff --git a/src/Settings/SettingsAction.hpp b/src/Settings/SettingsAction.hpp
index de795882b..6ba97d608 100644
--- a/src/Settings/SettingsAction.hpp
+++ b/src/Settings/SettingsAction.hpp
@@ -6,14 +6,16 @@
 #ifndef CHALET_SETTINGS_ACTION_HPP
 #define CHALET_SETTINGS_ACTION_HPP
 
+#include "Router/RouteType.hpp"
+
 namespace chalet
 {
-enum class SettingsAction : ushort
+enum class SettingsAction : std::underlying_type_t<RouteType>
 {
-	Get,
-	Set,
-	Unset,
-	QueryKeys,
+	Get = static_cast<std::underlying_type_t<RouteType>>(RouteType::SettingsGet),
+	Set = static_cast<std::underlying_type_t<RouteType>>(RouteType::SettingsSet),
+	Unset = static_cast<std::underlying_type_t<RouteType>>(RouteType::SettingsUnset),
+	QueryKeys = static_cast<std::underlying_type_t<RouteType>>(RouteType::SettingsGetKeys),
 };
 }
 
diff --git a/src/Terminal/Output.cpp b/src/Terminal/Output.cpp
index 23ad0c62b..93d38c51f 100644
--- a/src/Terminal/Output.cpp
+++ b/src/Terminal/Output.cpp
@@ -295,22 +295,6 @@ void Output::displayStyledSymbol(const Color inColor, const std::string_view inS
 	}
 }
 
-/*****************************************************************************/
-void Output::resetStdout()
-{
-	auto reset = getAnsiStyle(Color::Reset);
-	std::cout.write(reset.data(), reset.size());
-	std::cout.flush();
-}
-
-/*****************************************************************************/
-void Output::resetStderr()
-{
-	auto reset = getAnsiStyle(Color::Reset);
-	std::cerr.write(reset.data(), reset.size());
-	std::cerr.flush();
-}
-
 /*****************************************************************************/
 void Output::lineBreak(const bool inForce)
 {
diff --git a/src/Terminal/Output.hpp b/src/Terminal/Output.hpp
index 2c272fb45..15c7c02a6 100644
--- a/src/Terminal/Output.hpp
+++ b/src/Terminal/Output.hpp
@@ -43,8 +43,6 @@ std::string getAnsiStyleForMakefile(const Color inColor);
 std::string getAnsiStyleForceFormatting(const Color inColor, const Formatting inFormatting);
 
 void displayStyledSymbol(const Color inColor, const std::string_view inSymbol, const std::string& inMessage);
-void resetStdout();
-void resetStderr();
 void lineBreak(const bool inForce = false);
 void lineBreakStderr();
 void previousLine(const bool inForce = false);