Consider using ndarray::ArrayBase::all_close

[Robbepop]

I wonder if it is possible to simply use the all_close method from ArrayBase provided by the ndarray crate itself to simplify the implementation of the trait of this library. It also offers an eps value for approximate equality.

Have you considered using it?

[chalharu]

I also noticed that recently.
I believe it is unnecessary, but I have not deleted it yet.

[Robbepop]

In my library where I consider using your neat nearly-eq crate I am using ndarray's all_close method and am very happy about it. what may be problematic?

[chalharu]

There is no problem with ndarray's all_close method.
I want to remove the implementation for ndarray from nearly-eq.

[Robbepop]

What is the rational behind this decision?
I can imagine it being useful.

Actually when reading your crate README I saw what other libraries you have "batteries-included" implementations and I really liked that usability feature. One can say it was a selling point to me. :D

[chalharu]

Thank you for your idea.
Actually, wanted to handle Vec well, so I created this.
I will change to implementation using all_close method for ndarray.

[chalharu]

Because the all_close method needs to have the same Element type, ArrayBase<Data<Elem = f64>, Dimension> and ArrayBase<Data<Elem = f32>, Dimension> can not be compared.
I have no idea about implementing the method because the specialization is nightly feature.
(But this crate does not compare f32 and f64 yet.)