-
Notifications
You must be signed in to change notification settings - Fork 522
Description
For some reason, ExtraFieldFixtures.php contains the organisationemail twice for user fields: once as organisationemail directly, and another one as AzureAuthenticatorHelper::EXTRA_FIELD_ORGANISATION_EMAIL.
The second one is clearly needed for Azure authentication. The first one... not clear, so I would remove the first one, but this would require changing ExtraFieldFixtures.php and adding a migration to remove the duplicate.
This is also the case for azure_id (remove the first one).
Also, the display_text for:
LinkedInUrlshould sayLinkedIn profile URLVideoUrlshould sayVideo URLtagsshould sayTagsLegalshould sayLegal agreement acceptedGDPRTitleshould sayGDPRGDPRTextAreashould sayGDPR terms to be shown to users
Also, it would be necessary to have some kind of validation for extra_field.variable + extra_field.item_type to be unique, otherwise we end up with several fields with the same name.
But for alpha 5, we need at least the fix to remove the duplicate organisationemail.