Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Proposal: Theme Tag #78

Open
chanan opened this issue Mar 18, 2020 · 0 comments
Open

Feature Proposal: Theme Tag #78

chanan opened this issue Mar 18, 2020 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@chanan
Copy link
Owner

chanan commented Mar 18, 2020

Themes need some TLC... Maybe the ability to define a theme inside a tag will help something along the lines:

<Theme Name="MyTheme">
  colors.background: red;
</Theme>

or maybe json would be better?

<Theme Name="MyTheme">
{
  colors: {
    background: "red"
  }
}
</Theme>

HOCON could allow both syntaxes: https://github.com/akkadotnet/HOCON

The API will be updated to allow a theme update in one string:

IStyled.AddTheme("MyTheme", themeJsonOrString);

Lastly, need to add a way to switch between themes. API:

IStyled.SetTheme("MyTheme");

Not sure about a Tag version for that. Maybe:

<Theme SetTheme="MyTheme />
@chanan chanan added the enhancement New feature or request label Mar 18, 2020
@chanan chanan added this to the vNext milestone Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant