Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: GetThemeValue #96

Open
imtrobin opened this issue Jun 5, 2020 · 5 comments
Open

Feature: GetThemeValue #96

imtrobin opened this issue Jun 5, 2020 · 5 comments
Labels
question Further information is requested

Comments

@imtrobin
Copy link

imtrobin commented Jun 5, 2020

Hi, I can suggest add a IStyle.GetThemeValue (string)

I need to retrive it for theming with other libraries.

@chanan
Copy link
Owner

chanan commented Jun 5, 2020

Hi, I believe that exists, but also in the upcoming release the interface to get that changed a bit (hence the major version bump).

In addition, I plan to revamp all of themes in the future, just haven't figured out what I want to do yet

@chanan chanan added the question Further information is requested label Jun 5, 2020
@imtrobin
Copy link
Author

imtrobin commented Jun 6, 2020

the only one I see is GetThemeValuesAsync, which is retrieving as a IDictionary.

There is GetGlobalStyle (string name) but not GetThemeValue (string name)

@chanan
Copy link
Owner

chanan commented Jun 6, 2020

In the alpha of 3.0.0 that is on nuget (It is possible that maybe the current one on nuget doesnt have it?)

IDictionary<string, string> GetGlobalStyles();
string GetGlobalStyle(string name);

v3.0.0 will be released this weekend - you should be good once that is released.

@imtrobin
Copy link
Author

imtrobin commented Jun 6, 2020

I'm using the source code directly.
image

No worries, will wait for it, its weekend for me already.

@chanan
Copy link
Owner

chanan commented Jun 6, 2020

Sorry about that, must not have pushed to nuget for a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants