style: prefer Array.from over fill().map()

runesoerensen · runesoerensen · commit e9c59ec09f3b · 2025-08-23T06:35:32.000-04:00
diff --git a/testing.go b/testing.go
@@ -67,7 +67,7 @@ func (v *VHS) SaveOutput() error {
 // Buffer returns the current buffer.
 func (v *VHS) Buffer() ([]string, error) {
 	// Get the current buffer.
-	buf, err := v.Page.Eval("() => Array(term.rows).fill(0).map((_, i) => term.buffer.active.getLine(i + term.buffer.active.viewportY).translateToString().trimEnd())")
+	buf, err := v.Page.Eval("() => Array.from({ length: term.rows }, (_, i) => term.buffer.active.getLine(i + term.buffer.active.viewportY).translateToString().trimEnd())")
 	if err != nil {
 		return nil, fmt.Errorf("read buffer: %w", err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ func (v *VHS) SaveOutput() error {`
`67`	`67`	`// Buffer returns the current buffer.`
`68`	`68`	`func (v *VHS) Buffer() ([]string, error) {`
`69`	`69`	`// Get the current buffer.`
`70`		`- buf, err := v.Page.Eval("() => Array(term.rows).fill(0).map((_, i) => term.buffer.active.getLine(i + term.buffer.active.viewportY).translateToString().trimEnd())")`
	`70`	`+ buf, err := v.Page.Eval("() => Array.from({ length: term.rows }, (_, i) => term.buffer.active.getLine(i + term.buffer.active.viewportY).translateToString().trimEnd())")`
`71`	`71`	`if err != nil {`
`72`	`72`	`return nil, fmt.Errorf("read buffer: %w", err)`
`73`	`73`	`}`