Go upgrade (#7672)

* removing x509ignoreCN flag

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* updating the cert

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* increasing the timeout duration

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* upgrade to go 1.19

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* fix ha cluster pipeline

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* ha cluster fix for compliance scan verify

Signed-off-by: Abdul-Az <[email protected]>

* degub stmts added

Signed-off-by: Abdul-Az <[email protected]>

* degub stmts added

Signed-off-by: Abdul-Az <[email protected]>

* upgraded lib/pg

Signed-off-by: Abdul-Az <[email protected]>

* rebuild pkgs after lib/pq upgrade

Signed-off-by: Abdul-Az <[email protected]>

* go mod tidy

Signed-off-by: Abdul-Az <[email protected]>

* POSTGRESQL_URL changed to 127.0.0.1

Signed-off-by: Abdul-Az <[email protected]>

* fixing pg-side-car pipeline

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* pg-sidecar pipeline fix

Signed-off-by: Abdul-Az <[email protected]>

* code clean

Signed-off-by: Abdul-Az <[email protected]>

* fix repo health

Signed-off-by: Abdul-Az <[email protected]>

* added googleapis dependency

Signed-off-by: Abdul-Az <[email protected]>

* repo health fix

Signed-off-by: Abdul-Az <[email protected]>

* repo health fix

Signed-off-by: Abdul-Az <[email protected]>

* repo health fix

Signed-off-by: Abdul-Az <[email protected]>

* pq pkg upgraded

Signed-off-by: Abdul-Az <[email protected]>

* updating the cert generation doc

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* updating the mod files

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* fixing buildkite error

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

* updating golang version in SonarQube

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>

---------

Signed-off-by: Durga Sarat Chandra Maddu <[email protected]>
Signed-off-by: Abdul-Az <[email protected]>
Co-authored-by: Abdul-Az <[email protected]>

Author: Dmaddu

.expeditor/generate-automate-cli-docs.sh

@@ -1,8 +1,8 @@
 #!/bin/bash
 set -eou pipefail
 
-# bumping expeditor to go 1.13
-hab pkg install --binlink core/go/1.13.5 --force
+# bumping expeditor to go 1.19
+hab pkg install --binlink core/go19 --force
 
 pushd components/automate-cli
   make docs

.expeditor/license_scout.sh

@@ -40,10 +40,10 @@ log_section_start "Installing License Scout"
 gem install license_scout -v 2.5.1
 log "Finished Installing License Scout"
 
-log_section_start "Installing Go 1.15"
-hab pkg install --force --binlink core/go/1.15 && rm -rf /hab/cache && mkdir -p "$GOPATH/src" "$GOPATH/bin"
+log_section_start "Installing Go 1.19.3"
+hab pkg install --force --binlink core/go19/1.19.3 && rm -rf /hab/cache && mkdir -p "$GOPATH/src" "$GOPATH/bin"
 go version
-log "Finished Installing Go 1.15"
+log "Finished Installing Go 1.19.3"
 
 log_section_start "Installing Chef UI Library dependencies"
 pushd components/chef-ui-library

.expeditor/verify.pipeline.yml

@@ -217,7 +217,7 @@ steps:
       - scripts/install_golang.sh
       - scripts/setup_buildkite_pg.sh cereal_test
       - cd lib
-      - PG_USER="postgres" PATH=/usr/lib/postgresql/13/bin/:\$PATH GODEBUG=x509ignoreCN=0 make lint unit cereal_integration
+      - PG_USER="postgres" PATH=/usr/lib/postgresql/13/bin/:\$PATH make lint unit cereal_integration
     timeout_in_minutes: 10
     retry:
       automatic:
@@ -351,7 +351,8 @@ steps:
   - label: "[unit] chef-ui-library"
     command:
       - cd components/chef-ui-library
-      - npm install && npm run lint && npm run test
+      - node -v
+      - npm cache clean --force && npm install && npm run lint && npm run test
     timeout_in_minutes: 20
     retry:
       automatic:

.expeditor/verify_private.pipeline.yml

@@ -421,7 +421,7 @@ steps:
     command:
       - . scripts/verify_setup.sh
       - hab studio run "source scripts/verify_studio_init.sh && start_deployment_service && chef-automate dev deployinate && event_integration"
-    timeout_in_minutes: 10
+    timeout_in_minutes: 15
     expeditor:
       executor:
         docker:
@@ -759,7 +759,7 @@ steps:
   - label: "ontop backup"
     command:
       - integration/run_test integration/tests/backup_ontop.sh
-    timeout_in_minutes: 30
+    timeout_in_minutes: 40
     expeditor:
       executor:
         linux:

.github/workflows/build.yml

@@ -16,7 +16,7 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@v2
         with:
-          go-version: '1.15.0'
+          go-version: '1.19.3'
       - name: Test and coverage
         run: tools/go_coverage_report.sh
       - name: SonarQube Scan

.golangci.yml

@@ -14,11 +14,14 @@ linters-settings:
       - NOCOMMIT
   govet:
     disable:
+      - assign
+      - atomic
       - copylocks
 
 linters:
   enable-all: true
   disable:
+    - bodyclose
     - dogsled
     - dupl
     - funlen
@@ -28,6 +31,7 @@ linters:
     - goerr113
     - goimports
     - gomnd
+    - goprintffuncname
     - maligned
     - megacheck
     - nestif
@@ -45,3 +49,27 @@ linters:
     - lll
     - whitespace
     - wsl
+    - gci
+    - gofumpt
+    - gofmt
+    - gomoddirectives
+    - revive
+    - containedctx
+    - cyclop
+    - errorlint
+    - exhaustive
+    - exhaustivestruct
+    - forcetypeassert
+    - nlreturn
+    - nosnakecase
+    - tagliatelle
+    - varnamelen
+    - wrapcheck
+    - exhaustruct
+    - interfacebloat
+    - ireturn
+    - makezero
+    - maintidx
+    - nilerr
+    - nonamedreturns
+    - predeclared