Skip to content

Commit 92e4183

Browse files
authored
Jamie/4699 frontend update deps (#4835)
* Run npm update * ng update @ngrx/effects Signed-off-by: seajamied <[email protected]> * run ng update @angular-devkit/build-angular Signed-off-by: seajamied <[email protected]> * run ng update @nguniversal/express-engine Signed-off-by: seajamied <[email protected]> * Manually patch deprecation for @effect Signed-off-by: seajamied <[email protected]> * Updating @effect deprecation Unfortunately unable to use auto migrater, hitting an exception error Signed-off-by: seajamied <[email protected]> * More manual updating of effect to createEffect Signed-off-by: seajamied <[email protected]> * More manual updating effect to createEffect Signed-off-by: seajamied <[email protected]> * More manual updating effect to createEffect Signed-off-by: seajamied <[email protected]> * More manual updating effect to createEffect Signed-off-by: seajamied <[email protected]> * More effect updates, One error needs resolving Signed-off-by: seajamied <[email protected]> * All effect to createEffect updates made with exception to one error. Signed-off-by: seajamied <[email protected]> * Resolve CUSTOM_ELEMENTS_SCHEMA errors Signed-off-by: seajamied <[email protected]> * Fixed createEffect error. Thanks to new createEffect and Typescript, a should be non dispatching effect was found and updated. Signed-off-by: seajamied <[email protected]> * New fix updated dispatch false was the wrong approach - obvious by the fact that we needed to dispatch an action. However it appears we did not have a need to use mergeMap and instead should simply be merging. Signed-off-by: seajamied <[email protected]> * Bring angular packages up to 11.2.6 Signed-off-by: seajamied <[email protected]> * Update angular-devkit Signed-off-by: seajamied <[email protected]> * Update other angular packages to 11.2.5 This is the latest available to these packages Signed-off-by: seajamied <[email protected]> * Update @angular/cli to 11.2.5 Signed-off-by: seajamied <[email protected]> * Update zone.js to 0.11.4 Per documentation https://www.npmjs.com/package/zone.js\?activeTab\=readme a breaking change was introduced after v0.11.1, we are safe to upgrade by importing as 'zone.js/dist/zone' which we are doing in polyfills.ts Signed-off-by: seajamied <[email protected]> * Update documentation Signed-off-by: seajamied <[email protected]> * Updated package jwt-decode -> errors Initially I tought the package upgrade was causing errors but after making the required changes, I think what is actually happening is that it helped expose some bad tests or function in signin.component.ts. Interestingly enough, running 'make unit' shows that all tests are passing Signed-off-by: seajamied <[email protected]> * Update documentation Signed-off-by: seajamied <[email protected]> * Revert deleteServicesById$ - error The error is not infact fixed here, mergeMap seems to be required however there is a Type error that needs more investigation. The 'old' way works but the new way throws a type error Signed-off-by: seajamied <[email protected]> * Update return signature to be an Observable This fixed the effect error - thanks to Michael Sorens. This should be updated from an 'any' response as well. Signed-off-by: seajamied <[email protected]> * Update effects in rebased page Signed-off-by: seajamied <[email protected]> * Fix some mockselector errors from the master rebase Signed-off-by: seajamied <[email protected]> * Revert misplaced Mock Signed-off-by: seajamied <[email protected]> * Remove returns from createEffect Signed-off-by: seajamied <[email protected]> * Updating syntax of createEffects to remove returns Signed-off-by: seajamied <[email protected]> * More updating effect syntax Signed-off-by: seajamied <[email protected]> * More updating createEffects syntax Signed-off-by: seajamied <[email protected]> * Complete updates of createEffect syntax Signed-off-by: seajamied <[email protected]> * Rebase and update incoming effects Signed-off-by: seajamied <[email protected]> * Fix merge conflicts Signed-off-by: seajamied <[email protected]> * Weird left over merge issues resolved Signed-off-by: seajamied <[email protected]>
1 parent f52e93f commit 92e4183

File tree

51 files changed

+5863
-4151
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+5863
-4151
lines changed

components/automate-ui/README.md

+2-19
Original file line numberDiff line numberDiff line change
@@ -55,21 +55,9 @@ Certain packages in package.json are constrained for the reasons detailed here.
5555
At any future moment though, the reasons for constraint here could be invalidated, so this should be updated as needed when package.json is updated.
5656
While it is problematic to document this information due to the maintenance burden, the value of having this in one place outweighs that burden.
5757

58-
### Packages @ngrx/* =10.1.0
58+
### Package typescript: ^4.0.7
5959

60-
awaiting the release of ngrx 11. Until then, we will get incompatible peer dependencies if we try to update to latest.
61-
62-
### Package karma: ^5.1.1
63-
64-
"@angular-devkit/build-angular" has an incompatible peer dependency to Karma which requires ~5.1.0.
65-
66-
### Package typescript: ^4.0.5
67-
68-
"@angular-devkit/build-angular" has an incompatible peer dependency to typescript which requires ~4.0.0
69-
70-
### Package jwt-decode: ^2.2.0
71-
72-
Newer versions of jwt_decode introduce a new import format, which is breaking some of our testing.
60+
Package "@angular-devkit/build-angular" has an incompatible peer dependency to "typescript" (requires "~4.0.0 || ~4.1.0")
7361

7462
### Package immutable: ^3.8.2
7563

@@ -79,11 +67,6 @@ Reason: Later releases are release candidates; should only be using production-r
7967

8068
Per https://github.com/chef/automate/pull/1867, future versions have made a breaking change so it breaks our code base.
8169

82-
### Package zone.js: ^0.10.3
83-
84-
Per: https://www.npmjs.com/package/zone.js?activeTab=readme, Starting with v0.11.1, A breaking change is introduced for legacy browsers such as IE11. If we are no longer supporting IE 11, we are safe to upgrade, otherwise we can instead `import 'zone.js/dist/zone';`
85-
86-
There is a also an incompatible peer dependency with angular/core that will be cleared up in Angular 11.1.0 re: https://github.com/angular/angular/issues/39094#issuecomment-742227156
8770

8871
## Angular Module Architecture
8972

0 commit comments

Comments
 (0)