[deployment] Move list of services that use platform scaffolding out of deployment-service code into package.meta files. (#1126)

* Use package metadata to say whether a package uses platform scaffolding.

Fixes #1040.

Signed-off-by: Yvonne Lam <[email protected]>

* Regenerate bindata.

Signed-off-by: Yvonne Lam <[email protected]>

* Stop carrying around data unnecessarily.

Signed-off-by: Yvonne Lam <[email protected]>

Author: yzl

components/applications-service/package.meta

@@ -0,0 +1,4 @@
+{
+  "name": "chef/applications-service",
+  "uses_platform_scaffolding": true
+}

components/authn-service/package.meta

@@ -0,0 +1,4 @@
+{
+  "name": "chef/authn-service",
+  "uses_platform_scaffolding": true
+}

components/authz-service/package.meta

@@ -0,0 +1,4 @@
+{
+  "name": "chef/authz-service",
+  "uses_platform_scaffolding": true
+}

components/automate-cs-bookshelf/package.meta

@@ -0,0 +1,4 @@
+{
+  "name": "chef/automate-cs-bookshelf",
+  "uses_platform_scaffolding": true
+}

components/automate-cs-oc-bifrost/package.meta

@@ -0,0 +1,4 @@
+{
+  "name": "chef/automate-cs-oc-bifrost",
+  "uses_platform_scaffolding": true
+}

components/automate-cs-oc-erchef/package.meta

@@ -21,5 +21,6 @@
       "type": "file",
       "path": "data/dark_launch_features.json"
     }
-  ]
+  ],
+  "uses_platform_scaffolding": true
 }

components/automate-deployment/pkg/assets/assets.bindata.go

@@ -411,6 +411,7 @@ func (s *server) configRenderer() (ConfigRenderer, error) {
 		logrus.WithError(err).Error("Could not render platform config")
 		return nil, errors.Wrap(err, "Could not render platform config")
 	}
+
 	return func(service *deployment.Service) (string, error) {
 		rootCert := s.deployment.CA().RootCert()
 		creds := &config.TLSCredentials{
@@ -446,14 +447,8 @@ func (s *server) configRenderer() (ConfigRenderer, error) {
 }
 
 func usesPlatformScaffolding(service *deployment.Service) bool {
-	//TODO (jaym): find a better way to get this information
-	switch service.Name() {
-	case "secrets-service", "pg-sidecar-service", "teams-service", "authz-service", "session-service", "automate-dex",
-		"authn-service", "compliance-service", "nodemanager-service", "notifications-service", "applications-service",
-		"automate-cs-bookshelf", "automate-cs-oc-erchef", "automate-cs-oc-bifrost", "ingest-service", "license-control-service":
-		return true
-	}
-	return false
+	metadata := services.MetadataForPackage(service.Name())
+	return metadata != nil && metadata.UsesPlatformScaffolding
 }
 
 func (s *errDeployer) convergeServices(task *converge.Task, eventSink converge.EventSink) {

components/automate-deployment/pkg/server/server.go

@@ -0,0 +1,4 @@
+{
+  "name": "chef/automate-dex",
+  "uses_platform_scaffolding": true
+}

components/automate-deployment/pkg/services/internal/generated/gen.go

@@ -0,0 +1,4 @@
+{
+  "name": "chef/compliance-service",
+  "uses_platform_scaffolding": true
+}

components/automate-dex/package.meta

@@ -0,0 +1,4 @@
+{
+  "name": "chef/ingest-service",
+  "uses_platform_scaffolding": true
+}

components/compliance-service/package.meta

@@ -0,0 +1,4 @@
+{
+  "name": "chef/license-control-service",
+  "uses_platform_scaffolding": true
+}

components/ingest-service/package.meta

@@ -0,0 +1,4 @@
+{
+  "name": "chef/nodemanager-service",
+  "uses_platform_scaffolding": true
+}

components/license-control-service/package.meta

@@ -0,0 +1,4 @@
+{
+  "name": "chef/notifications-service",
+  "uses_platform_scaffolding": true
+}