Modify Internal Protos to Conform to the Linter (#4230)

Modify the internal protobuf messages to conform to the linter. This way we can have the fewest exceptions to the lint rules which will reduce the feeling that the linter is inconsistent.

* Enforce FIELD_LOWER_SNAKE_CASE proto rule for interservice protos
* Enforce more linter rules on interservice protos
* Add lint exception to compliance profile proto
* I fought the type checker and won and then lost
* fix the rest of event service test
* prepare to normalize request type names for interservice
* Enforce SERVICE_SUFFIX for protos where possible
* Fix `build_all_changed` not failing on error
* Add some doc comments to buf.yaml
* More updates for service suffix style rule
* Deployment proto service definition is external and shouldn't change
* improve wording of buf.yaml rationale
* More updates for service suffix
* Fixup healthchecks for service suffix
* Add exception to service suffix for the purge service
* More service suffix fixes

Author: danielsdeleo

.studio/common

@@ -134,7 +134,12 @@ function compile_client_mocks() {
       #
       # https://github.com/golang/mock/issues/156#issuecomment-586213812
       #
-      mockgen_debug -destination cfgmgmt/service/cfgmgmt.pb.client_mock.go -package service -self_package github.com/chef/automate/api/interservice/cfgmgmt/service github.com/chef/automate/api/interservice/cfgmgmt/service CfgMgmtClient,CfgMgmt_NodeExportClient,CfgMgmt_ReportExportClient,CfgMgmtServer,CfgMgmt_NodeExportServer,CfgMgmt_ReportExportServer
+      mockgen_debug -destination cfgmgmt/service/cfgmgmt.pb.client_mock.go \
+        -package service \
+        -self_package \
+        github.com/chef/automate/api/interservice/cfgmgmt/service \
+        github.com/chef/automate/api/interservice/cfgmgmt/service \
+        CfgMgmtServiceClient,CfgMgmtService_NodeExportClient,CfgMgmtService_ReportExportClient,CfgMgmtServiceServer,CfgMgmtService_NodeExportServer,CfgMgmtService_ReportExportServer
       mockgen_debug -source ingest/chef.pb.go -destination ingest/chef.pb.client_mock.go -package ingest -self_package github.com/chef/automate/api/interservice/ingest
       mockgen_debug -source event_feed/event_feed.pb.go -destination event_feed/event_feed.pb.client_mock.go -package event_feed -self_package github.com/chef/automate/api/interservice/event_feed
       mockgen_debug -source nodemanager/manager/manager.pb.go -destination nodemanager/manager/manager.pb.client_mock.go -package manager -self_package github.com/chef/automate/api/interservice/nodemanager/manager
@@ -530,11 +535,17 @@ function build_all_changed_components() {
       if [[ -n "$whitelist" ]]; then
         if [[ "$whitelist" == *"$(basename "$component")"* ]]; then
           log_line "Building $component"
-          build "$component"
+          if ! build "$component"; then
+            popd
+            return 1
+          fi
         fi
       else
         log_line "Building $component"
-        build "$component"
+        if ! build "$component"; then
+          popd
+          return 1
+        fi
       fi
     done
   popd >/dev/null

.studio/ingest-service

@@ -49,36 +49,36 @@ document "mark_nodes_missing" <<DOC
   Run the mark nodes missing job now
 DOC
 function mark_nodes_missing() {
-  ingest_grpcurl_get chef.automate.domain.ingest.JobScheduler.MarkNodesMissing
+  ingest_grpcurl_get chef.automate.domain.ingest.JobSchedulerService.MarkNodesMissing
 }
 
 function ingest_version() {
-  ingest_grpcurl_get chef.automate.domain.ingest.ChefIngester.GetVersion
+  ingest_grpcurl_get chef.automate.domain.ingest.ChefIngesterService.GetVersion
 }
 
 document "ingest_job_status" <<DOC
   Get the Job Scheduler's status
 DOC
 function ingest_job_status() {
-  ingest_grpcurl_get chef.automate.domain.ingest.JobScheduler.GetStatusJobScheduler
+  ingest_grpcurl_get chef.automate.domain.ingest.JobSchedulerService.GetStatusJobScheduler
 }
 
 document "ingest_job_stop" <<DOC
   Stop the Job Scheduler
 DOC
 function ingest_job_stop() {
-  ingest_grpcurl_get chef.automate.domain.ingest.JobScheduler.StopJobScheduler
+  ingest_grpcurl_get chef.automate.domain.ingest.JobSchedulerService.StopJobScheduler
 }
 
 document "ingest_job_start" <<DOC
   Start the Job Scheduler
 DOC
 function ingest_job_start() {
-  ingest_grpcurl_get chef.automate.domain.ingest.JobScheduler.StartJobScheduler
+  ingest_grpcurl_get chef.automate.domain.ingest.JobSchedulerService.StartJobScheduler
 }
 
 function ingest_migration_status() {
-  ingest_grpcurl_get chef.automate.domain.ingest.IngestStatus.GetMigrationStatus
+  ingest_grpcurl_get chef.automate.domain.ingest.IngestStatusService.GetMigrationStatus
 }
 
 function install_ingest_test_framework {
@@ -283,9 +283,9 @@ document "ingest_grpcurl_list_services" <<DOC
 
   @(arg:1) Optional: An RPC service to inspec
 
-  Example: Inspect the ChefIngester service
+  Example: Inspect the ChefIngesterService service
   -----------------------------
-  ingest_grpcurl_list_services chef.automate.domain.ingest.ChefIngester
+  ingest_grpcurl_list_services chef.automate.domain.ingest.ChefIngesterService
 DOC
 function ingest_grpcurl_list_services() {
   chef-automate dev grpcurl ingest-service -- list "$1"
@@ -298,7 +298,7 @@ document "ingest_grpcurl_get" <<DOC
 
   Example: Get the migration status (GetMigrationStatus)
   -----------------------------
-  ingest_grpcurl_get chef.automate.domain.ingest.IngestStatus.GetMigrationStatus
+  ingest_grpcurl_get chef.automate.domain.ingest.IngestStatusService.GetMigrationStatus
 
   NOTE: Run 'ingest_grpcurl_list_services' to inspec the RPC services.
 DOC