Chefstyle fixes

Lint this repo

Signed-off-by: Tim Smith <[email protected]>

Author: tas50

Gemfile

@@ -1,2 +1,2 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 gemspec

Rakefile

@@ -1,46 +1,47 @@
 #!/usr/bin/env rake
-require 'bundler/gem_tasks'
-require 'json'
+require "bundler/gem_tasks"
+require "json"
 
-task :default => ['validate:json', 'spec']
+task default: ["validate:json", "spec"]
 
 namespace :validate do
-  desc 'Validate mock platform data is valid JSON'
+  desc "Validate mock platform data is valid JSON"
   task :json do
     failure = false
-    Dir.glob('./lib/fauxhai/platforms/**/*.json') do |file|
+    Dir.glob("./lib/fauxhai/platforms/**/*.json") do |file|
       begin
         JSON.parse(File.read(file))
-      rescue JSON::ParserError => e
+      rescue JSON::ParserError
         failure = true
         puts "Failed to parse #{file}."
       end
     end
     exit! if failure
-    puts 'JSON files validated'
+    puts "JSON files validated"
   end
 end
 
 namespace :documentation do
-  desc 'Update the PLATFORMS.md file with a list of all platforms'
+  desc "Update the PLATFORMS.md file with a list of all platforms"
   task :update_platforms do
-    File.delete('PLATFORMS.md') if File.exist?('PLATFORMS.md')
-    f = File.new('PLATFORMS.md', 'w')
+    File.delete("PLATFORMS.md") if File.exist?("PLATFORMS.md")
+    f = File.new("PLATFORMS.md", "w")
     f.write "## Fauxhai Platforms\n\nThis file lists each platform known to Fauxhai and the available versions for each of those platforms. See the ChefSpec documentation for mocking out platforms and platform versions within ChefSpec.\n"
-    Dir.glob('./lib/fauxhai/platforms/**').sort.each do |platform_path|
-      next if platform_path.split('/')[-1] == 'chefspec'
+    Dir.glob("./lib/fauxhai/platforms/**").sort.each do |platform_path|
+      next if platform_path.split("/")[-1] == "chefspec"
+
       versions = []
-      Dir.glob(File.join(platform_path, '**.json')).sort.each do |version_path|
+      Dir.glob(File.join(platform_path, "**.json")).sort.each do |version_path|
         # skip anything marked as deprecated
         data = JSON.parse(File.read(version_path))
-        unless data['deprecated']
-          versions << version_path.split('/')[-1].chomp('.json')
+        unless data["deprecated"]
+          versions << version_path.split("/")[-1].chomp(".json")
         end
       end
       # make sure there are any non-deprecated platforms before writing out the header
       unless versions.empty?
-        f.write "\n### #{platform_path.split('/')[-1]}\n\n"
-        versions = versions.sort_by { |v| Gem::Version.new(v) } unless platform_path.split('/')[-1] == 'windows' # make sure we're sorted by version and not by strings
+        f.write "\n### #{platform_path.split("/")[-1]}\n\n"
+        versions = versions.sort_by { |v| Gem::Version.new(v) } unless platform_path.split("/")[-1] == "windows" # make sure we're sorted by version and not by strings
         versions.each do |v|
           f.write "  - #{v}\n"
         end
@@ -50,5 +51,5 @@ namespace :documentation do
   end
 end
 
-require 'rspec/core/rake_task'
+require "rspec/core/rake_task"
 RSpec::Core::RakeTask.new(:spec)

bin/fauxhai

@@ -1,23 +1,23 @@
 #!/usr/bin/env ruby
 
-lib = File.expand_path(File.dirname(__FILE__) + '../../lib')
+lib = File.expand_path(File.dirname(__FILE__) + "../../lib")
 $LOAD_PATH.unshift(lib) if File.directory?(lib) && !$LOAD_PATH.include?(lib)
 
 args = ARGV.dup
 ARGV.clear
 
-unless (args & ['-v', '--version']).empty?
-  require 'fauxhai/version'
+unless (args & ["-v", "--version"]).empty?
+  require "fauxhai/version"
   puts Fauxhai::VERSION
   exit(0)
 end
 
-unless (args & ['-h', '--help']).empty?
-  puts 'Usage: fauxhai'
-  puts '(There are no flags or options)'
+unless (args & ["-h", "--help"]).empty?
+  puts "Usage: fauxhai"
+  puts "(There are no flags or options)"
   exit(0)
 end
 
-require 'fauxhai'
-require 'fauxhai/runner'
+require "fauxhai"
+require "fauxhai/runner"
 Fauxhai::Runner.new(args)

fauxhai-ng.gemspec

@@ -1,28 +1,28 @@
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $:.unshift(lib) unless $:.include?(lib)
-require 'fauxhai/version'
+require "fauxhai/version"
 
 Gem::Specification.new do |spec|
-  spec.name          = 'fauxhai-ng'
+  spec.name          = "fauxhai-ng"
   spec.version       = Fauxhai::VERSION
-  spec.authors       = ['Seth Vargo', 'Tim Smith']
-  spec.email         = ['[email protected]', '[email protected]']
-  spec.description   = 'Easily mock out ohai data'
-  spec.summary       = 'Fauxhai provides an easy way to mock out your ohai data for testing with chefspec!'
-  spec.homepage      = 'https://github.com/chefspec/fauxhai'
-  spec.license       = 'MIT'
+  spec.authors       = ["Seth Vargo", "Tim Smith"]
+  spec.email         = ["[email protected]", "[email protected]"]
+  spec.description   = "Easily mock out ohai data"
+  spec.summary       = "Fauxhai provides an easy way to mock out your ohai data for testing with chefspec!"
+  spec.homepage      = "https://github.com/chefspec/fauxhai"
+  spec.license       = "MIT"
 
-  spec.required_ruby_version = '>= 2.3'
+  spec.required_ruby_version = ">= 2.3"
 
   spec.files         = %w{LICENSE} + Dir.glob("{lib,bin}/**/*", File::FNM_DOTMATCH).reject { |f| File.directory?(f) }
-  spec.executables   = 'fauxhai'
-  spec.require_paths = ['lib']
+  spec.executables   = "fauxhai"
+  spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency 'net-ssh'
+  spec.add_runtime_dependency "net-ssh"
 
-  spec.add_development_dependency 'chef', '>= 13.0'
-  spec.add_development_dependency 'ohai', '>= 13.0'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rspec', '~> 3.7'
-  spec.add_development_dependency 'rspec-its', '~> 1.2'
+  spec.add_development_dependency "chef", ">= 13.0"
+  spec.add_development_dependency "ohai", ">= 13.0"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rspec", "~> 3.7"
+  spec.add_development_dependency "rspec-its", "~> 1.2"
 end

lib/fauxhai.rb

@@ -1,11 +1,11 @@
 module Fauxhai
-  autoload :Exception, 'fauxhai/exception'
-  autoload :Fetcher, 'fauxhai/fetcher'
-  autoload :Mocker, 'fauxhai/mocker'
-  autoload :VERSION, 'fauxhai/version'
+  autoload :Exception, "fauxhai/exception"
+  autoload :Fetcher, "fauxhai/fetcher"
+  autoload :Mocker, "fauxhai/mocker"
+  autoload :VERSION, "fauxhai/version"
 
   def self.root
-    @@root ||= File.expand_path('../../', __FILE__)
+    @@root ||= File.expand_path("../../", __FILE__)
   end
 
   def self.mock(*args, &block)

lib/fauxhai/fetcher.rb

@@ -1,6 +1,6 @@
-require 'digest/sha1'
-require 'json'
-require 'net/ssh'
+require "digest/sha1"
+require "json"
+require "net/ssh"
 
 module Fauxhai
   class Fetcher
@@ -11,11 +11,11 @@ def initialize(options = {}, &override_attributes)
         @data = cache
       else
         Net::SSH.start(host, user, @options) do |ssh|
-          @data = JSON.parse(ssh.exec!('ohai'))
+          @data = JSON.parse(ssh.exec!("ohai"))
         end
 
         # cache this data so we do not have to SSH again
-        File.open(cache_file, 'w+') { |f| f.write(@data.to_json) }
+        File.open(cache_file, "w+") { |f| f.write(@data.to_json) }
       end
 
       yield(@data) if block_given?
@@ -45,7 +45,7 @@ def cache_key
     end
 
     def cache_file
-      File.expand_path(File.join(Fauxhai.root, 'tmp', cache_key))
+      File.expand_path(File.join(Fauxhai.root, "tmp", cache_key))
     end
 
     def force_cache_miss?
@@ -67,13 +67,14 @@ def to_s
 
     def host
       @host ||= begin
-        raise ArgumentError, ':host is a required option for Fauxhai.fetch' unless @options[:host]
+        raise ArgumentError, ":host is a required option for Fauxhai.fetch" unless @options[:host]
+
         @options.delete(:host)
       end
     end
 
     def user
-      @user ||= (@options.delete(:user) || ENV['USER'] || ENV['USERNAME']).chomp
+      @user ||= (@options.delete(:user) || ENV["USER"] || ENV["USERNAME"]).chomp
     end
   end
 end

lib/fauxhai/mocker.rb

@@ -1,14 +1,14 @@
-require 'json'
-require 'pathname'
-require 'open-uri'
+require "json"
+require "pathname"
+require "open-uri"
 
 module Fauxhai
   class Mocker
     # The base URL for the GitHub project (raw)
-    RAW_BASE = 'https://raw.githubusercontent.com/chefspec/fauxhai/master'.freeze
+    RAW_BASE = "https://raw.githubusercontent.com/chefspec/fauxhai/master".freeze
 
     # A message about where to find a list of platforms
-    PLATFORM_LIST_MESSAGE = 'A list of available platforms is available at https://github.com/chefspec/fauxhai/blob/master/PLATFORMS.md'.freeze
+    PLATFORM_LIST_MESSAGE = "A list of available platforms is available at https://github.com/chefspec/fauxhai/blob/master/PLATFORMS.md".freeze
 
     # Create a new Ohai Mock with fauxhai.
     #
@@ -58,7 +58,7 @@ def data
             FileUtils.mkdir_p(path.dirname)
 
             begin
-              File.open(filepath, 'w') { |f| f.write(response_body) }
+              File.open(filepath, "w") { |f| f.write(response_body) }
             rescue Errno::EACCES # a pretty common problem in CI systems
               puts "Fetched '#{platform}/#{version}' from GitHub, but could not write to the local path: #{filepath}. Fix the local file permissions to avoid downloading this file every run."
             end
@@ -79,21 +79,21 @@ def data
     # and eventually remove them while giving end users ample warning.
     def parse_and_validate(unparsed_data)
       parsed_data = JSON.parse(unparsed_data)
-      if parsed_data['deprecated']
-        STDERR.puts "WARNING: Fauxhai platform data for #{parsed_data['platform']} #{parsed_data['platform_version']} is deprecated and will be removed in the 9.0 release 3/2021. #{PLATFORM_LIST_MESSAGE}"
+      if parsed_data["deprecated"]
+        STDERR.puts "WARNING: Fauxhai platform data for #{parsed_data["platform"]} #{parsed_data["platform_version"]} is deprecated and will be removed in the 9.0 release 3/2021. #{PLATFORM_LIST_MESSAGE}"
       end
       parsed_data
     end
 
     def platform
       @options[:platform] ||= begin
                                 STDERR.puts "WARNING: you must specify a 'platform' and optionally a 'version' for your ChefSpec Runner and/or Fauxhai constructor, in the future omitting the platform will become a hard error. #{PLATFORM_LIST_MESSAGE}"
-                                'chefspec'
+                                "chefspec"
                               end
     end
 
     def platform_path
-      File.join(Fauxhai.root, 'lib', 'fauxhai', 'platforms', platform)
+      File.join(Fauxhai.root, "lib", "fauxhai", "platforms", platform)
     end
 
     def version
@@ -103,13 +103,13 @@ def version
           @options[:version]
         else
           # Check if it's a prefix of an existing version.
-          versions = Dir["#{platform_path}/*.json"].map {|path| File.basename(path, '.json') }
-          unless @options[:version].to_s == ''
+          versions = Dir["#{platform_path}/*.json"].map { |path| File.basename(path, ".json") }
+          unless @options[:version].to_s == ""
             # If the provided version is nil or '', that means take anything,
             # otherwise run the prefix match with an extra \D to avoid the
             # case where "7.1" matches "7.10.0".
             prefix_re = /^#{Regexp.escape(@options[:version])}\D/
-            versions.select! {|ver| ver =~ prefix_re }
+            versions.select! { |ver| ver =~ prefix_re }
           end
 
           if versions.empty?

lib/fauxhai/runner.rb

@@ -1,41 +1,41 @@
-require 'ohai'
-require 'ohai/plugins/chef'
+require "ohai"
+require "ohai/plugins/chef"
 
 module Fauxhai
   class Runner
     def initialize(args)
       @system = Ohai::System.new
       @system.all_plugins
 
-      case @system.data['platform']
-      when 'windows', :windows
-        require_relative 'runner/windows'
-        self.singleton_class.send :include, ::Fauxhai::Runner::Windows
+      case @system.data["platform"]
+      when "windows", :windows
+        require_relative "runner/windows"
+        singleton_class.send :include, ::Fauxhai::Runner::Windows
       else
-        require_relative 'runner/default'
-        self.singleton_class.send :include, ::Fauxhai::Runner::Default
+        require_relative "runner/default"
+        singleton_class.send :include, ::Fauxhai::Runner::Default
       end
 
       result = @system.data.dup.delete_if { |k, v| !whitelist_attributes.include?(k) }.merge(
-        'languages' => languages,
-        'counters' => counters,
-        'current_user' => current_user,
-        'domain' => domain,
-        'hostname' => hostname,
-        'machinename' => hostname,
-        'fqdn' => fqdn,
-        'ipaddress' => ipaddress,
-        'keys' => keys,
-        'macaddress' => macaddress,
-        'network' => network,
-        'uptime' => uptime,
-        'uptime_seconds' => uptime_seconds,
-        'idle' => uptime,
-        'idletime_seconds' => uptime_seconds,
-        'cpu' => cpu,
-        'memory' => memory,
-        'virtualization' => virtualization,
-        'time' => time
+        "languages" => languages,
+        "counters" => counters,
+        "current_user" => current_user,
+        "domain" => domain,
+        "hostname" => hostname,
+        "machinename" => hostname,
+        "fqdn" => fqdn,
+        "ipaddress" => ipaddress,
+        "keys" => keys,
+        "macaddress" => macaddress,
+        "network" => network,
+        "uptime" => uptime,
+        "uptime_seconds" => uptime_seconds,
+        "idle" => uptime,
+        "idletime_seconds" => uptime_seconds,
+        "cpu" => cpu,
+        "memory" => memory,
+        "virtualization" => virtualization,
+        "time" => time
       )
 
       puts JSON.pretty_generate(result.sort.to_h)