Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ionic 5 + capacitor 3.5 iOS non-modular-header issue #108

Open
marshall86 opened this issue Jul 27, 2022 · 3 comments
Open

ionic 5 + capacitor 3.5 iOS non-modular-header issue #108

marshall86 opened this issue Jul 27, 2022 · 3 comments

Comments

@marshall86
Copy link

Hi, as per subject I'm getting an error with the latest cordova plugin for firebase dynamic links using Ionic 5 and Capacitor 3.5.
Xcode doesn't manage to create the build, It fails with "non-modular-header" issue while importing firebase.

Any idea on how to fix it pls? Thanks

@chemerisuk
Copy link
Owner

@marshall86 please paste full build log here.

@marshall86
Copy link
Author

Hi, I don't have the full log handy right now but this was the error

Include of non-modular header inside framework module 'CordovaPlugins.FirebaseDynamicLinksPlugin': 'ios/App/Pods/Headers/Public/Firebase/Firebase.h'
#import <Firebase/Firebase.h>

@marshall86
Copy link
Author

marshall86 commented Dec 1, 2022

here a more accurate log of the error:

:1:9: note: in file included from :1:
#import "Headers/CordovaPlugins-umbrella.h"
^
/Users/marshall86/Documents/repo/dipV5_ionic6/ios/App/Pods/Target Support Files/CordovaPlugins/CordovaPlugins-umbrella.h:19:9: note: in file included from /Users/marshall86/Documents/repo/dipV5_ionic6/ios/App/Pods/Target Support Files/CordovaPlugins/CordovaPlugins-umbrella.h:19:
#import "FirebaseDynamicLinksPlugin.h"
^
/Users/marshall86/Documents/repo/dipV5_ionic6/ios/capacitor-cordova-ios-plugins/sources/CordovaPluginFirebaseDynamiclinks/FirebaseDynamicLinksPlugin.h:4:9: error: include of non-modular header inside framework module 'CordovaPlugins.FirebaseDynamicLinksPlugin': '/Users/marshall86/Documents/repo/dipV5_ionic6/ios/App/Pods/Headers/Public/Firebase/Firebase.h'
#import <Firebase/Firebase.h>
^
:0: error: could not build Objective-C module 'CordovaPlugins'

In the meantime i upgraded the app to Ionic 6 and Capacitor 3.9.0

Ionic:

Ionic Framework : @ionic/angular 6.3.9
@angular-devkit/build-angular : 14.2.10
@angular-devkit/schematics : 14.2.10
@angular/cli : 14.2.10
@ionic/angular-toolkit : 7.0.0

Capacitor:

Capacitor CLI : 3.9.0
@capacitor/core : 3.9.0

Cordova:

Cordova CLI : 8.1.1 ([email protected])
Cordova Platforms : not available
Cordova Plugins : not available

Utility:

cordova-res : 0.15.3
native-run : 1.7.1

System:

NodeJS : v14.18.0
npm : 6.14.15

Package.json:

"dependencies": {
"@angular/common": "^14.2.12",
"@angular/core": "^14.2.12",
"@angular/forms": "^14.2.12",
"@angular/platform-browser": "^14.2.12",
"@angular/platform-browser-dynamic": "^14.2.12",
"@angular/router": "^14.2.12",
"@awesome-cordova-plugins/call-number": "6.2.0",
"@awesome-cordova-plugins/core": "5.39.0",
"@awesome-cordova-plugins/deeplinks": "6.2.0",
"@awesome-cordova-plugins/email-composer": "6.2.0",
"@awesome-cordova-plugins/fingerprint-aio": "6.2.0",
"@awesome-cordova-plugins/firebase-dynamic-links": "5.39.0",
"@awesome-cordova-plugins/in-app-browser": "6.2.0",
"@awesome-cordova-plugins/market": "6.2.0",
"@capacitor/android": "3.9.0",
"@capacitor/app": "^1.1.1",
"@capacitor/camera": "^1.3.1",
"@capacitor/clipboard": "^1.0.8",
"@capacitor/core": "^3.9.0",
"@capacitor/device": "^1.1.2",
"@capacitor/haptics": "^1.1.4",
"@capacitor/ios": "^3.9.0",
"@capacitor/network": "^1.0.7",
"@capacitor/share": "^1.1.2",
"@capacitor/splash-screen": "^1.2.2",
"@capacitor/status-bar": "^1.0.8",
"@capacitor/storage": "^1.2.5",
"@ionic-native/core": "^5.36.0",
"@ionic-native/firebase-dynamic-links": "^5.36.0",
"@ionic-native/jumio": "^5.36.0",
"@ionic/angular": "^6.3.8",
"@ionic/angular-toolkit": "^7.0.0",
"call-number": "^1.0.1",
"chart.js": "^4.0.1",
"cordova-plugin-email-composer": "^0.10.0",
"cordova-plugin-fingerprint-aio": "^5.0.1",
"cordova-plugin-firebase-analytics": "^6.1.0",
"cordova-plugin-firebase-dynamiclinks": "^6.1.3",
"cordova-plugin-inappbrowser": "^5.0.0",
"cordova-plugin-market": "^1.2.0",
"cordova-support-android-plugin": "^1.0.2",
"crypto-js": "^3.0.0",
"es6-promise-plugin": "^4.2.2",
"ionic-plugin-deeplinks": "^1.0.22",
"jetifier": "^2.0.0",
"jumio-cordova-plugin-mobilesdk": "^3.9.2",
"ngx-paypal": "^10.1.0",
"rxjs": "~6.6.3",
"swiper": "^8.4.5",
"tslib": "^2.3.0",
"webpack-bundle-analyzer": "^4.4.2",
"zone.js": "^0.12.0"
},
"devDependencies": {
"@angular-devkit/architect": "0.1402.10",
"@angular-devkit/build-angular": "^14.2.10",
"@angular-eslint/builder": "14.2.0",
"@angular-eslint/eslint-plugin": "14.2.0",
"@angular-eslint/eslint-plugin-template": "14.2.0",
"@angular-eslint/schematics": "14.2.0",
"@angular-eslint/template-parser": "14.2.0",
"@angular/cli": "^14.2.10",
"@angular/compiler": "^14.2.12",
"@angular/compiler-cli": "^14.2.12",
"@angular/language-service": "^14.2.12",
"@capacitor/cli": "^3.9.0",
"@ionic/cli": "6.20.4",
"@types/crypto-js": "^3.1.47",
"@types/jasmine": "^4.3.0",
"@types/jasminewd2": "^2.0.9",
"@types/node": "^16.6.1",
"@typescript-eslint/eslint-plugin": "^5.44.0",
"@typescript-eslint/parser": "^5.44.0",
"eslint": "^8.28.0",
"jasmine-core": "^4.5.0",
"jasmine-spec-reporter": "~7.0.0",
"karma": "^6.3.4",
"karma-chrome-launcher": "^3.1.0",
"karma-coverage-istanbul-reporter": "^3.0.3",
"karma-jasmine": "^5.1.0",
"karma-jasmine-html-reporter": "^2.0.0",
"protractor": "^7.0.0",
"ts-node": "^10.2.0",
"typescript": "4.8.4"
},

Would be great to get some help on the matter please. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants