fix: remove redundant std::move for a local object in a return statement

zhyncs · chenshuo · commit 0f3cb975510e · 2019-12-01T16:09:15.000-08:00
diff --git a/muduo/base/BlockingQueue.h b/muduo/base/BlockingQueue.h
@@ -52,7 +52,7 @@ class BlockingQueue : noncopyable
     assert(!queue_.empty());
     T front(std::move(queue_.front()));
     queue_.pop_front();
-    return std::move(front);
+    return front;
   }
 
   size_t size() const
diff --git a/muduo/base/BoundedBlockingQueue.h b/muduo/base/BoundedBlockingQueue.h
@@ -62,7 +62,7 @@ class BoundedBlockingQueue : noncopyable
     T front(std::move(queue_.front()));
     queue_.pop_front();
     notFull_.notify();
-    return std::move(front);
+    return front;
   }
 
   bool empty() const

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ class BlockingQueue : noncopyable`
`52`	`52`	`assert(!queue_.empty());`
`53`	`53`	`T front(std::move(queue_.front()));`
`54`	`54`	`queue_.pop_front();`
`55`		`- return std::move(front);`
	`55`	`+ return front;`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`size_t size() const`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ class BoundedBlockingQueue : noncopyable`
`62`	`62`	`T front(std::move(queue_.front()));`
`63`	`63`	`queue_.pop_front();`
`64`	`64`	`notFull_.notify();`
`65`		`- return std::move(front);`
	`65`	`+ return front;`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`bool empty() const`