Remove SSLConnectionProxyMeta using class decorator

Author: julianz-

.DS_Store

@@ -129,7 +129,7 @@ per-file-ignores =
   cheroot/makefile.py: DAR101, DAR201, DAR401, E800, I003, I004, N801, N802, S101, WPS100, WPS110, WPS111, WPS117, WPS120, WPS121, WPS122, WPS123, WPS130, WPS204, WPS210, WPS212, WPS213, WPS220, WPS229, WPS231, WPS232, WPS338, WPS420, WPS422, WPS429, WPS431, WPS504, WPS604, WPS606
   cheroot/server.py: DAR003, DAR101, DAR201, DAR202, DAR301, DAR401, E800, I001, I003, I004, I005, N806, RST201, RST301, RST303, RST304, WPS100, WPS110, WPS111, WPS115, WPS120, WPS121, WPS122, WPS130, WPS132, WPS201, WPS202, WPS204, WPS210, WPS211, WPS212, WPS213, WPS214, WPS220, WPS221, WPS225, WPS226, WPS229, WPS230, WPS231, WPS236, WPS237, WPS238, WPS301, WPS338, WPS342, WPS410, WPS420, WPS421, WPS422, WPS429, WPS432, WPS504, WPS505, WPS601, WPS602, WPS608, WPS617
   cheroot/ssl/builtin.py: DAR101, DAR201, DAR401, I001, I003, N806, RST304, WPS110, WPS111, WPS115, WPS117, WPS120, WPS121, WPS122, WPS130, WPS201, WPS210, WPS214, WPS229, WPS231, WPS338, WPS422, WPS501, WPS505, WPS529, WPS608, WPS612
-  cheroot/ssl/pyopenssl.py: C815, DAR101, DAR201, DAR401, I001, I003, I005, N801, N804, RST304, WPS100, WPS110, WPS111, WPS117, WPS120, WPS121, WPS130, WPS210, WPS220, WPS221, WPS225, WPS229, WPS231, WPS238, WPS301, WPS335, WPS338, WPS420, WPS422, WPS430, WPS432, WPS501, WPS504, WPS505, WPS601, WPS608, WPS615
+  cheroot/ssl/pyopenssl.py: C815, DAR101, DAR201, DAR401, I001, I003, I005, N801, N804, RST304, WPS100, WPS110, WPS111, WPS117, WPS120, WPS121, WPS130, WPS210, WPS220, WPS221, WPS225, WPS229, WPS231, WPS238, WPS301, WPS335, WPS338, WPS420, WPS422, WPS430, WPS432, WPS501, WPS504, WPS505, WPS601, WPS602, WPS608, WPS615
   cheroot/test/conftest.py: DAR101, DAR201, DAR301, I001, I003, I005, WPS100, WPS130, WPS325, WPS354, WPS420, WPS422, WPS430, WPS457
   cheroot/test/helper.py: DAR101, DAR201, DAR401, I001, I003, I004, N802, WPS110, WPS111, WPS121, WPS201, WPS220, WPS231, WPS301, WPS414, WPS421, WPS422, WPS505
   cheroot/test/ssl/test_ssl_pyopenssl.py: DAR101, DAR201, WPS226

.flake8

@@ -0,0 +1,9 @@
+{
+    "python.defaultInterpreterPath": "/Users/julian/Documents/GitHub/cheroot/.venv/bin/python",
+    "python.testing.pytestEnabled": true,
+    "python.testing.pytestPath": "/Users/julian/Documents/GitHub/cheroot/.venv/bin/pytest",
+    "python.testing.pytestArgs": [
+        "--rootdir=.", 
+        "--import-mode=importlib" // Optional: A modern import mode that may help
+    ]
+}

.vscode/settings.json

@@ -216,92 +216,89 @@ class SSLFileobjectStreamWriter(SSLFileobjectMixin, StreamWriter):
     """SSL file object attached to a socket object."""
 
 
-class SSLConnectionProxyMeta:
-    """Metaclass for generating a bunch of proxy methods."""
-
-    def __new__(mcl, name, bases, nmspc):
-        """Attach a list of proxy methods to a new class."""
-        proxy_methods = (
-            'get_context',
-            'pending',
-            'send',
-            'write',
-            'recv',
-            'read',
-            'renegotiate',
-            'bind',
-            'listen',
-            'connect',
-            'accept',
-            'setblocking',
-            'fileno',
-            'close',
-            'get_cipher_list',
-            'getpeername',
-            'getsockname',
-            'getsockopt',
-            'setsockopt',
-            'makefile',
-            'get_app_data',
-            'set_app_data',
-            'state_string',
-            'sock_shutdown',
-            'get_peer_certificate',
-            'want_read',
-            'want_write',
-            'set_connect_state',
-            'set_accept_state',
-            'connect_ex',
-            'sendall',
-            'settimeout',
-            'gettimeout',
-            'shutdown',
-        )
-        proxy_methods_no_args = ('shutdown',)
-
-        proxy_props = ('family',)
-
-        def lock_decorator(method):
-            """Create a proxy method for a new class."""
-
-            def proxy_wrapper(self, *args):
-                new_args = (
-                    args[:] if method not in proxy_methods_no_args else []
-                )
-                # translate any SysCallError to ConnectionError
-                with _morph_syscall_to_connection_error(method), self._lock:
-                    return getattr(self._ssl_conn, method)(*new_args)
-
-            return proxy_wrapper
-
-        for m in proxy_methods:
-            nmspc[m] = lock_decorator(m)
-            nmspc[m].__name__ = m
-
-        def make_property(property_):
-            """Create a proxy method for a new class."""
-
-            def proxy_prop_wrapper(self):
-                return getattr(self._ssl_conn, property_)
-
-            proxy_prop_wrapper.__name__ = property_
-            return property(proxy_prop_wrapper)
-
-        for p in proxy_props:
-            nmspc[p] = make_property(p)
+# Wrapper function to dynamically add thread-safe methods and properties
+def _wrap_ssl_connection_methods(cls):
+    """Dynamically attaches proxied methods and properties to the class."""
+    # 1. Attach Methods
+    for method in cls.proxy_methods:
+        wrapped_func = cls._lock_decorator(method)
+        setattr(cls, method, wrapped_func)
+
+    # 2. Attach Properties
+    for prop in cls.proxy_props:
+        setattr(cls, prop, cls._make_property(prop))
+
+    return cls
+
+
+@_wrap_ssl_connection_methods
+class SSLConnection:
+    """A thread-safe wrapper around :py:class:`SSL.Connection <pyopenssl:OpenSSL.SSL.Connection>`."""
+
+    proxy_methods = (
+        'get_context',
+        'pending',
+        'send',
+        'write',
+        'recv',
+        'read',
+        'renegotiate',
+        'bind',
+        'listen',
+        'connect',
+        'accept',
+        'setblocking',
+        'fileno',
+        'close',
+        'get_cipher_list',
+        'getpeername',
+        'getsockname',
+        'getsockopt',
+        'setsockopt',
+        'makefile',
+        'get_app_data',
+        'set_app_data',
+        'state_string',
+        'sock_shutdown',
+        'get_peer_certificate',
+        'want_read',
+        'want_write',
+        'set_connect_state',
+        'set_accept_state',
+        'connect_ex',
+        'sendall',
+        'settimeout',
+        'gettimeout',
+        'shutdown',
+    )
+    proxy_methods_no_args = ('shutdown',)
+    proxy_props = ('family',)
+
+    @staticmethod
+    def _lock_decorator(method):
+        """Create the thread-safe, error-translating proxy method."""
+
+        def proxy_wrapper(self, *args):
+            new_args = (
+                args[:]
+                if method not in SSLConnection.proxy_methods_no_args
+                else []
+            )
+            with self._lock, _morph_syscall_to_connection_error(method):
+                return getattr(self._ssl_conn, method)(*new_args)
 
-        # Doesn't work via super() for some reason.
-        # Falling back to type() instead:
-        return type(name, bases, nmspc)
+        proxy_wrapper.__name__ = method
+        return proxy_wrapper
 
+    @staticmethod
+    def _make_property(property_):
+        """Create the property proxy."""
 
-class SSLConnection(metaclass=SSLConnectionProxyMeta):
-    r"""A thread-safe wrapper for an ``SSL.Connection``.
+        def proxy_prop_wrapper(self):
+            return getattr(self._ssl_conn, property_)
 
-    :param tuple args: the arguments to create the wrapped \
-                        :py:class:`SSL.Connection(*args) \
-                        <pyopenssl:OpenSSL.SSL.Connection>`
-    """
+        proxy_prop_wrapper.__name__ = property_
+        return property(proxy_prop_wrapper)
 
     def __init__(self, *args):
         """Initialize SSLConnection instance."""

cheroot/ssl/pyopenssl.py

@@ -18,10 +18,11 @@ class SSLFileobjectMixin:
 class SSLFileobjectStreamReader(SSLFileobjectMixin, StreamReader): ...  # type:ignore[misc]
 class SSLFileobjectStreamWriter(SSLFileobjectMixin, StreamWriter): ...  # type:ignore[misc]
 
-class SSLConnectionProxyMeta:
-    def __new__(mcl, name, bases, nmspc): ...
-
 class SSLConnection:
+    proxy_methods: tuple[str, ...]
+    proxy_methods_no_args: tuple[str, ...]
+    proxy_props: tuple[str, ...]
+
     def __init__(self, *args) -> None: ...
 
 class pyOpenSSLAdapter(Adapter):