Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

questions about "quality" and "score" #7

Open
Cheng111 opened this issue Jul 8, 2019 · 1 comment
Open

questions about "quality" and "score" #7

Cheng111 opened this issue Jul 8, 2019 · 1 comment
Labels

Comments

@Cheng111
Copy link

Cheng111 commented Jul 8, 2019

Hi, in your paper you mentioned that "Peaks receive a “quality” value, which is the value of the second derivative of the KDE." and "Peaks also get assigned a “score”, which is a product of quality and delta mass peak intensity." But I have two questions.

  1. In my output table, it looks like that the score doesn't equal to intensity multiple quality. Here is an example of my output table
    image
  2. The peak curve is a curve if concave function. Its second derivative should be a non-positive number. Why the "quality" in the table are all positive numbers. Are they the absolute value of the second derivative?
@chhh
Copy link
Owner

chhh commented Jul 16, 2019

  1. I think it has been changed since the paper came out. Score is currently calculated as quality * PSM support, here's the line where that happens:
    score = quality * gmmc.psmSupportApprox;
  2. Yes, that's the absolute value so that it was less confusing and to help with natural sorting.

@chhh chhh added the wiki label Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants