Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question about subscription syntax #59

Open
farnic0 opened this issue Mar 17, 2022 · 1 comment
Open

Question about subscription syntax #59

farnic0 opened this issue Mar 17, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@farnic0
Copy link

farnic0 commented Mar 17, 2022 •
edited
Loading

1
1_1
Worked

2
2_1
Worked

4
4_1
Didn't work :(

It still didn't work on UpdateArmorSet, Boss Checklist, etc.
Is it normal that it doesn't work?
@sgkoishi
Copy link
Member

This is the feature of the tModLoader.

https://github.com/tModLoader/tModLoader/blob/206196e2463d4e92545162153977cc8f8907e876/patches/tModLoader/Terraria.ModLoader/ModContent.cs#L578

ProcessCopyCommandsInTexts only works for localized content in the dictionary, so it is not guaranteed to work for all ldstr entries. In fact, most entries are likely not being handled by this function.

The support for this syntax is planned everything planned but nobody actually works on them 😂

@sgkoishi sgkoishi added the enhancement New feature or request label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgkoishi @farnic0