Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation says base_name, should probably be basename #278

Open
dyve opened this issue Dec 13, 2019 · 2 comments
Open

Documentation says base_name, should probably be basename #278

dyve opened this issue Dec 13, 2019 · 2 comments

Comments

@dyve
Copy link

dyve commented Dec 13, 2019

Documentation: http://chibisov.github.io/drf-extensions/docs/#nested-routes

router = ExtendedSimpleRouter()
(
    router.register(r'users', UserViewSet, base_name='user')
          .register(r'groups',
                    GroupViewSet,
                    base_name='users-group',
                    parents_query_lookups=['user_groups'])
          .register(r'permissions',
                    PermissionViewSet,
                    base_name='users-groups-permission',
                    parents_query_lookups=['group__user', 'group'])
)
urlpatterns = router.urls

Parameter base_name is not accepted, but looking at the source, basename is.

I cannot find a changelog for this change, please clarify and update documentation.

@auvipy
Copy link
Collaborator

auvipy commented Dec 13, 2019

you are right

@dyve dyve changed the title Documentation says base_name, should probably be base_name Documentation says base_name, should probably be basename Dec 13, 2019
@shuternay
Copy link

It seems that the documentation page hasn't been updated since 2016: https://github.com/chibisov/drf-extensions/commits/gh-pages
In the source file it is basename: https://github.com/chibisov/drf-extensions/blob/master/docs/index.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants