Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memroy #263

Open
ideamean opened this issue Mar 3, 2017 · 3 comments
Open

memroy #263

ideamean opened this issue Mar 3, 2017 · 3 comments

Comments

@ideamean
Copy link

ideamean commented Mar 3, 2017

when press the key that bind, the browser's memory is increase higher and higher, why?

@aramando
Copy link

aramando commented Mar 3, 2017

@ideamean It's most likely due to the code you've registered as the callback for the hotkey. Can you post it here?

@ideamean
Copy link
Author

ideamean commented Mar 6, 2017

hotkeys.bindTo($scope).add({
combo: 'left',
description: 'action_map_mode_submit',
callback: function (event, hotkey) {
// even if here is no code, memory will continue to rise
// press the "left" key, memory will increase
}
})

@aramando
Copy link

aramando commented Mar 6, 2017

That's weird, I created a Plunk to test and I can't reproduce this. Even after 2000 hotkey presses there was absolutely no increase in the memory used.

Does it depend which browser you use? Can you create a Plunk or similar that demonstrates the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants